Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Issue 2089783004: Correctly fallback to caret bounds when composition_head is not provided (Closed)

Created:
4 years, 6 months ago by oshima
Modified:
4 years, 6 months ago
Reviewers:
Shu Chen
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org, Azure Wei
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly fallback to caret bounds when composition_head is not provided BUG=622448 TEST=manual Committed: https://crrev.com/a517f584d88458b14aac79589a515e7d8c58665d Cr-Commit-Position: refs/heads/master@{#401485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ui/base/ime/input_method_chromeos.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
oshima
4 years, 6 months ago (2016-06-22 20:34:32 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089783004/1
4 years, 6 months ago (2016-06-22 20:36:15 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 21:31:03 UTC) #8
Shu Chen
lgtm. Thank you for the fix!
4 years, 6 months ago (2016-06-23 00:25:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089783004/1
4 years, 6 months ago (2016-06-23 00:44:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 00:50:44 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 00:52:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a517f584d88458b14aac79589a515e7d8c58665d
Cr-Commit-Position: refs/heads/master@{#401485}

Powered by Google App Engine
This is Rietveld 408576698