Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2091663002: Make callers of FromUTC(Local)Exploded in google_apis/ use new time API. (Closed)

Created:
4 years, 6 months ago by maksims (do not use this acc)
Modified:
4 years, 1 month ago
Reviewers:
hidehiko, fukino
CC:
chromium-reviews, fukino
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make callers of FromUTC(Local)Exploded in google_apis/ use new time API. Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601900 Committed: https://crrev.com/e20a6fdd7a74a53b83a8be5a1db0119e77f8cacc Cr-Commit-Position: refs/heads/master@{#430660}

Patch Set 1 #

Total comments: 8

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Patch Set 6 : typo #

Patch Set 7 : rebased and set dependent patch #

Total comments: 2

Patch Set 8 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -25 lines) Patch
M google_apis/drive/drive_api_requests_unittest.cc View 1 2 3 4 5 6 7 5 chunks +41 lines, -14 lines 0 comments Download
M google_apis/drive/time_util.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M google_apis/drive/time_util_unittest.cc View 1 2 3 4 3 chunks +13 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 55 (38 generated)
maksims (do not use this acc)
please review
4 years, 5 months ago (2016-07-05 11:23:43 UTC) #6
maksims (do not use this acc)
please review
4 years, 5 months ago (2016-07-05 11:24:14 UTC) #8
hidehiko
FYI: fukino@. Could you run trybots? https://codereview.chromium.org/2091663002/diff/80001/google_apis/drive/drive_api_requests_unittest.cc File google_apis/drive/drive_api_requests_unittest.cc (right): https://codereview.chromium.org/2091663002/diff/80001/google_apis/drive/drive_api_requests_unittest.cc#newcode569 google_apis/drive/drive_api_requests_unittest.cc:569: base::Time LastViewedByMeDateUTC; base::Time ...
4 years, 5 months ago (2016-07-05 17:31:14 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091663002/80001
4 years, 5 months ago (2016-07-06 01:38:16 UTC) #11
maksims (do not use this acc)
On 2016/07/05 17:31:14, hidehiko wrote: > FYI: fukino@. > > Could you run trybots? > ...
4 years, 5 months ago (2016-07-06 12:18:40 UTC) #13
hidehiko
On 2016/07/06 12:18:40, maksims wrote: > On 2016/07/05 17:31:14, hidehiko wrote: > > FYI: fukino@. ...
4 years, 5 months ago (2016-07-07 17:23:33 UTC) #14
maksims (do not use this acc)
On 2016/07/07 17:23:33, hidehiko wrote: > On 2016/07/06 12:18:40, maksims wrote: > > On 2016/07/05 ...
4 years, 5 months ago (2016-07-08 12:25:10 UTC) #15
maksims_
On 2016/07/08 12:25:10, maksims wrote: > On 2016/07/07 17:23:33, hidehiko wrote: > > On 2016/07/06 ...
4 years, 1 month ago (2016-10-24 14:41:01 UTC) #39
hidehiko
Only style comments. https://codereview.chromium.org/2091663002/diff/80001/google_apis/drive/drive_api_requests_unittest.cc File google_apis/drive/drive_api_requests_unittest.cc (right): https://codereview.chromium.org/2091663002/diff/80001/google_apis/drive/drive_api_requests_unittest.cc#newcode569 google_apis/drive/drive_api_requests_unittest.cc:569: base::Time LastViewedByMeDateUTC; On 2016/07/05 17:31:14, hidehiko ...
4 years, 1 month ago (2016-10-25 16:37:05 UTC) #40
maksims (do not use this acc)
https://codereview.chromium.org/2091663002/diff/80001/google_apis/drive/drive_api_requests_unittest.cc File google_apis/drive/drive_api_requests_unittest.cc (right): https://codereview.chromium.org/2091663002/diff/80001/google_apis/drive/drive_api_requests_unittest.cc#newcode569 google_apis/drive/drive_api_requests_unittest.cc:569: base::Time LastViewedByMeDateUTC; On 2016/07/05 17:31:14, hidehiko wrote: > base::Time ...
4 years, 1 month ago (2016-10-26 11:55:27 UTC) #45
maksims (do not use this acc)
gentle reminder
4 years, 1 month ago (2016-11-02 06:54:33 UTC) #46
hidehiko
On 2016/11/02 06:54:33, maksims wrote: > gentle reminder Oops, very sorry. LGTM. Defer to fukino@.
4 years, 1 month ago (2016-11-02 16:46:27 UTC) #47
maksims (do not use this acc)
fukino@, do you have any comments?
4 years, 1 month ago (2016-11-03 05:46:04 UTC) #48
fukino
LGTM. I'm sorry for a late response!
4 years, 1 month ago (2016-11-08 03:25:47 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091663002/220001
4 years, 1 month ago (2016-11-08 17:18:40 UTC) #51
commit-bot: I haz the power
Committed patchset #8 (id:220001)
4 years, 1 month ago (2016-11-08 18:27:29 UTC) #53
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 18:38:47 UTC) #55
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/e20a6fdd7a74a53b83a8be5a1db0119e77f8cacc
Cr-Commit-Position: refs/heads/master@{#430660}

Powered by Google App Engine
This is Rietveld 408576698