Make callers of FromUTC(Local)Exploded in google_apis/ use new time API.

google_apis/drive/drive_api_requests_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/drive/drive_api_requests.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <utility>
 
@@ skipping 547 matching lines @@
   // Create "new directory" in the root directory.
   {
     base::RunLoop run_loop;
     drive::FilesInsertRequest* request = new drive::FilesInsertRequest(
         request_sender_.get(),
         *url_generator_,
         test_util::CreateQuitCallback(
             &run_loop,
             test_util::CreateCopyResultCallback(&error, &file_resource)));
     request->set_visibility(drive::FILE_VISIBILITY_PRIVATE);
-    request->set_last_viewed_by_me_date(
-        base::Time::FromUTCExploded(kLastViewedByMeDate));
+
+    base::Time LastViewedByMeDateUTC;

[hidehiko, 2016/07/05 17:31:14]

base::Time last_viewed_by_me_date_utc;

to follow the style guide. Ditto for below.

[hidehiko, 2016/10/25 16:37:05]

ping.

[maksims (do not use this acc), 2016/10/26 11:55:27]

Done.

+    EXPECT_TRUE(base::Time::FromUTCExploded(kLastViewedByMeDate,

[hidehiko, 2016/07/05 17:31:14]

Could you use ASSERT_TRUE? Ditto for below.

[hidehiko, 2016/10/25 16:37:05]

ping.

[maksims (do not use this acc), 2016/10/26 11:55:27]

Done.

+                                            &LastViewedByMeDateUTC));
+

[hidehiko, 2016/07/05 17:31:14]

nit: could you remove this empty line? L573 looks to belong to L569-571 block
conceptually, to me. Ditto for below.

[hidehiko, 2016/10/25 16:37:05]

ping.

+    request->set_last_viewed_by_me_date(LastViewedByMeDateUTC);
     request->set_mime_type("application/vnd.google-apps.folder");
-    request->set_modified_date(base::Time::FromUTCExploded(kModifiedDate));
+
+    base::Time ModifiedDateUTC;
+    EXPECT_TRUE(base::Time::FromUTCExploded(kModifiedDate, &ModifiedDateUTC));
+
+    request->set_modified_date(ModifiedDateUTC);
     request->add_parent("root");
     request->set_title("new directory");
     request->set_properties(testing_properties_);
     request_sender_->StartRequestWithAuthRetry(request);
     run_loop.Run();
   }
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   EXPECT_EQ(net::test_server::METHOD_POST, http_request_.method);
   EXPECT_EQ("/drive/v2/files?visibility=PRIVATE", http_request_.relative_url);
@@ skipping 41 matching lines @@
         request_sender_.get(),
         *url_generator_,
         test_util::CreateQuitCallback(
             &run_loop,
             test_util::CreateCopyResultCallback(&error, &file_resource)));
     request->set_file_id("resource_id");
     request->set_set_modified_date(true);
     request->set_update_viewed_date(false);
 
     request->set_title("new title");
-    request->set_modified_date(base::Time::FromUTCExploded(kModifiedDate));
-    request->set_last_viewed_by_me_date(
-        base::Time::FromUTCExploded(kLastViewedByMeDate));
+
+    base::Time ModifiedDateUTC;
+    EXPECT_TRUE(base::Time::FromUTCExploded(kModifiedDate, &ModifiedDateUTC));
+
+    request->set_modified_date(ModifiedDateUTC);
+
+    base::Time LastViewedByMeDateUTC;
+    EXPECT_TRUE(base::Time::FromUTCExploded(kLastViewedByMeDate,
+                                            &LastViewedByMeDateUTC));
+
+    request->set_last_viewed_by_me_date(LastViewedByMeDateUTC);
     request->add_parent("parent_resource_id");
 
     request->set_properties(testing_properties_);
     request_sender_->StartRequestWithAuthRetry(request);
     run_loop.Run();
   }
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   EXPECT_EQ(net::test_server::METHOD_PATCH, http_request_.method);
   EXPECT_EQ("/drive/v2/files/resource_id"
@@ skipping 173 matching lines @@
   {
     base::RunLoop run_loop;
     drive::FilesCopyRequest* request = new drive::FilesCopyRequest(
         request_sender_.get(),
         *url_generator_,
         test_util::CreateQuitCallback(
             &run_loop,
             test_util::CreateCopyResultCallback(&error, &file_resource)));
     request->set_visibility(drive::FILE_VISIBILITY_PRIVATE);
     request->set_file_id("resource_id");
-    request->set_modified_date(base::Time::FromUTCExploded(kModifiedDate));
+
+    base::Time ModifiedDateUTC;
+    EXPECT_TRUE(base::Time::FromUTCExploded(kModifiedDate, &ModifiedDateUTC));
+
+    request->set_modified_date(ModifiedDateUTC);
     request->add_parent("parent_resource_id");
     request->set_title("new title");
     request_sender_->StartRequestWithAuthRetry(request);
     run_loop.Run();
   }
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   EXPECT_EQ(net::test_server::METHOD_POST, http_request_.method);
   EXPECT_EQ("/drive/v2/files/resource_id/copy?visibility=PRIVATE",
             http_request_.relative_url);
@@ skipping 596 matching lines @@
         new drive::InitiateUploadNewFileRequest(
             request_sender_.get(),
             *url_generator_,
             kTestContentType,
             kTestContent.size(),
             "parent_resource_id",  // The resource id of the parent directory.
             "new file title",  // The title of the file being uploaded.
             test_util::CreateQuitCallback(
                 &run_loop,
                 test_util::CreateCopyResultCallback(&error, &upload_url)));
-    request->set_modified_date(base::Time::FromUTCExploded(kModifiedDate));
-    request->set_last_viewed_by_me_date(
-        base::Time::FromUTCExploded(kLastViewedByMeDate));
+
+    base::Time ModifiedDateUTC;
+    EXPECT_TRUE(base::Time::FromUTCExploded(kModifiedDate, &ModifiedDateUTC));
+
+    request->set_modified_date(ModifiedDateUTC);
+
+    base::Time LastViewedByMeDateUTC;
+    EXPECT_TRUE(base::Time::FromUTCExploded(kLastViewedByMeDate,
+                                            &LastViewedByMeDateUTC));
+
+    request->set_last_viewed_by_me_date(LastViewedByMeDateUTC);
     request_sender_->StartRequestWithAuthRetry(request);
     run_loop.Run();
   }
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   EXPECT_EQ(kTestUploadNewFilePath, upload_url.path());
   EXPECT_EQ(kTestContentType, http_request_.headers["X-Upload-Content-Type"]);
   EXPECT_EQ(base::SizeTToString(kTestContent.size()),
             http_request_.headers["X-Upload-Content-Length"]);
 
@@ skipping 354 matching lines @@
             *url_generator_,
             kTestContentType,
             kTestContent.size(),
             "resource_id",  // The resource id of the file to be overwritten.
             kTestETag,
             test_util::CreateQuitCallback(
                 &run_loop,
                 test_util::CreateCopyResultCallback(&error, &upload_url)));
     request->set_parent_resource_id("new_parent_resource_id");
     request->set_title("new file title");
-    request->set_modified_date(base::Time::FromUTCExploded(kModifiedDate));
-    request->set_last_viewed_by_me_date(
-        base::Time::FromUTCExploded(kLastViewedByMeDate));
+
+    base::Time ModifiedDateUTC;
+    EXPECT_TRUE(base::Time::FromUTCExploded(kModifiedDate, &ModifiedDateUTC));
+
+    request->set_modified_date(ModifiedDateUTC);
+
+    base::Time LastViewedByMeDateUTC;
+    EXPECT_TRUE(base::Time::FromUTCExploded(kLastViewedByMeDate,
+                                            &LastViewedByMeDateUTC));
+
+    request->set_last_viewed_by_me_date(LastViewedByMeDateUTC);
 
     request_sender_->StartRequestWithAuthRetry(request);
     run_loop.Run();
   }
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   EXPECT_EQ(kTestUploadExistingFilePath, upload_url.path());
   EXPECT_EQ(kTestContentType, http_request_.headers["X-Upload-Content-Type"]);
   EXPECT_EQ(base::SizeTToString(kTestContent.size()),
             http_request_.headers["X-Upload-Content-Length"]);
@@ skipping 455 matching lines @@
                                     "Header: value\r\n"
                                     "\r\n"
                                     "BODY\r\n"
                                     "--BOUNDARY-- \t",
                                     &parts));
   ASSERT_EQ(1u, parts.size());
   EXPECT_EQ(HTTP_SUCCESS, parts[0].code);
   EXPECT_EQ("BODY", parts[0].body);
 }
 }  // namespace google_apis