In --site-per-process, don't try to call beforeunload on subframes yet.

In --site-per-process, don't try to call beforeunload on subframes yet.

Also update SitePerProcessBrowserTest to allow browser-initiated
subframe navigations.

BUG=304341
TEST=Click a link in an OOP iframe when using --site-per-process.


[Closed; this is stale]

[Charlie Reis, 2014-03-21 23:24:33]

Nasko: I noticed that we were crashing when clicking a link in an OOP iframe
after my beforeunload CL, since we don't yet support beforeunload on subframes. 
I updated the test framework to be able to exercise it.

https://codereview.chromium.org/209153003/diff/1/content/browser/frame_host/r...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/209153003/diff/1/content/browser/frame_host/r...
content/browser/frame_host/render_frame_host_manager.cc:417: // Sanity check
that this is for the correct frame.
This check only makes sense for transfers, not browser-initiated navigations
(like I've just made possible in the test).

https://codereview.chromium.org/209153003/diff/1/content/browser/site_per_pro...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/209153003/diff/1/content/browser/site_per_pro...
content/browser/site_per_process_browsertest.cc:197: void
NavigateFrameToURL(WebContents* web_contents,
This should make iframe tests a bit easier to write, since we don't need to
worry about cross-origin access in the script call.

I'm also hoping to use it to write a nested iframe test, but I haven't figured
out how to get the test to wait for the right events yet.

https://codereview.chromium.org/209153003/diff/1/content/browser/site_per_pro...
content/browser/site_per_process_browsertest.cc:271: // Load another cross-site
page into the same iframe.
This second navigation tests the beforeunload crash I mentioned.

[nasko, 2014-03-22 04:07:16]

Couple of comments, but LGTM.

https://codereview.chromium.org/209153003/diff/1/content/browser/site_per_pro...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/209153003/diff/1/content/browser/site_per_pro...
content/browser/site_per_process_browsertest.cc:197: void
NavigateFrameToURL(WebContents* web_contents,
On 2014/03/21 23:24:33, Charlie Reis wrote:
> This should make iframe tests a bit easier to write, since we don't need to
> worry about cross-origin access in the script call.
> 
> I'm also hoping to use it to write a nested iframe test, but I haven't figured
> out how to get the test to wait for the right events yet.

Wouldn't WCO::DidNavigateAnyFrame help us here? We just need one of the *Watcher
type objects.

Also, wouldn't be better to have those methods in
content/test/content_browser_test_utils.*?