In --site-per-process, don't try to call beforeunload on subframes yet.

content/browser/site_per_process_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/strings/stringprintf.h"
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/public/browser/notification_observer.h"
@@ skipping 151 matching lines @@
   // Start at a data URL so each extra navigation creates a navigation entry.
   // (The first navigation will silently be classified as AUTO_SUBFRAME.)
   // TODO(creis): This won't be necessary when we can wait for LOAD_STOP.
   void StartFrameAtDataURL() {
     std::string data_url_script =
       "var iframes = document.getElementById('test');iframes.src="
       "'data:text/html,dataurl';";
     ASSERT_TRUE(ExecuteScript(shell()->web_contents(), data_url_script));
   }
 
-  bool NavigateIframeToURL(Shell* window,
-                           const GURL& url,
-                           std::string iframe_id) {
+  // Navigates a frame using JavaScript in the renderer process, causing a
+  // cross-process transfer navigation.
+  bool NavigateFrameToURLInRenderer(Shell* window,
+                                    const GURL& url,
+                                    std::string iframe_id) {
     // TODO(creis): This should wait for LOAD_STOP, but cross-site subframe
     // navigations generate extra DidStartLoading and DidStopLoading messages.
     // Until we replace swappedout:// with frame proxies, we need to listen for
     // something else.  For now, we trigger NEW_SUBFRAME navigations and listen
     // for commit.
     std::string script = base::StringPrintf(
         "setTimeout(\""
         "var iframes = document.getElementById('%s');iframes.src='%s';"
         "\",0)",
         iframe_id.c_str(), url.spec().c_str());
     WindowedNotificationObserver load_observer(
         NOTIFICATION_NAV_ENTRY_COMMITTED,
         Source<NavigationController>(
             &window->web_contents()->GetController()));
     bool result = ExecuteScript(window->web_contents(), script);
     load_observer.Wait();
     return result;
   }
 
+  // Navigates a frame via the browser process, with no transfer.
+  void NavigateFrameToURL(WebContents* web_contents,

[Charlie Reis, 2014/03/21 23:24:33]

This should make iframe tests a bit easier to write, since we don't need to
worry about cross-origin access in the script call.

I'm also hoping to use it to write a nested iframe test, but I haven't figured
out how to get the test to wait for the right events yet.

[nasko, 2014/03/22 04:07:17]

Wouldn't WCO::DidNavigateAnyFrame help us here? We just need one of the *Watcher
type objects.

Also, wouldn't be better to have those methods in
content/test/content_browser_test_utils.*?

+                          FrameTreeNode* node,
+                          const GURL& url) {
+    // TODO(creis): This should wait for LOAD_STOP, but cross-site subframe
+    // navigations generate extra DidStartLoading and DidStopLoading messages.
+    // Until we replace swappedout:// with frame proxies, we need to listen for
+    // something else.  For now, we listen for commit.
+    WindowedNotificationObserver load_observer(
+        NOTIFICATION_NAV_ENTRY_COMMITTED,
+        Source<NavigationController>(
+            &web_contents->GetController()));
+    NavigationController::LoadURLParams params(url);
+    params.transition_type = PageTransitionFromInt(PAGE_TRANSITION_LINK);
+    params.frame_tree_node_id = node->frame_tree_node_id();
+    web_contents->GetController().LoadURLWithParams(params);
+    load_observer.Wait();
+  }
+
   virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
     command_line->AppendSwitch(switches::kSitePerProcess);
 
     // TODO(creis): Remove this when GTK is no longer a supported platform.
     command_line->AppendSwitch(switches::kForceCompositingMode);
   }
 };
 
 // Ensure that we can complete a cross-process subframe navigation.
 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, CrossSiteIframe) {
   host_resolver()->AddRule("*", "127.0.0.1");
   ASSERT_TRUE(test_server()->Start());
   GURL main_url(test_server()->GetURL("files/site_per_process_main.html"));
   NavigateToURL(shell(), main_url);
 
   StartFrameAtDataURL();
 
   SitePerProcessWebContentsObserver observer(shell()->web_contents());
 
   // Load same-site page into iframe.
   GURL http_url(test_server()->GetURL("files/title1.html"));
-  EXPECT_TRUE(NavigateIframeToURL(shell(), http_url, "test"));
+  EXPECT_TRUE(NavigateFrameToURLInRenderer(shell(), http_url, "test"));
   EXPECT_EQ(http_url, observer.navigation_url());
   EXPECT_TRUE(observer.navigation_succeeded());
 
-  // These must stay in scope with replace_host.
-  GURL::Replacements replace_host;
-  std::string foo_com("foo.com");
-
-  // Load cross-site page into iframe.
-  GURL cross_site_url(test_server()->GetURL("files/title2.html"));
-  replace_host.SetHostStr(foo_com);
-  cross_site_url = cross_site_url.ReplaceComponents(replace_host);
-  EXPECT_TRUE(NavigateIframeToURL(shell(), cross_site_url, "test"));
-  EXPECT_EQ(cross_site_url, observer.navigation_url());
-  EXPECT_TRUE(observer.navigation_succeeded());
-
-  // Ensure that we have created a new process for the subframe.
   FrameTreeNode* root =
       static_cast<WebContentsImpl*>(shell()->web_contents())->
           GetFrameTree()->root();
   ASSERT_EQ(1U, root->child_count());
   FrameTreeNode* child = root->child_at(0);
-  EXPECT_NE(shell()->web_contents()->GetRenderViewHost(),
-            child->current_frame_host()->render_view_host());
-  EXPECT_NE(shell()->web_contents()->GetSiteInstance(),
-            child->current_frame_host()->render_view_host()->GetSiteInstance());
-  EXPECT_NE(shell()->web_contents()->GetRenderProcessHost(),
-            child->current_frame_host()->GetProcess());
+  EXPECT_EQ(shell()->web_contents()->GetSiteInstance(),
+            child->current_frame_host()->GetSiteInstance());
+
+  // These must stay in scope with replace_host.
+  GURL::Replacements replace_host;
+  std::string foo_com("foo.com");
+  std::string bar_com("bar.com");
+
+  // Load cross-site page into iframe.
+  GURL foo_url(test_server()->GetURL("files/title2.html"));
+  replace_host.SetHostStr(foo_com);
+  foo_url = foo_url.ReplaceComponents(replace_host);
+  EXPECT_TRUE(NavigateFrameToURLInRenderer(shell(), foo_url, "test"));
+  EXPECT_EQ(foo_url, observer.navigation_url());
+  EXPECT_TRUE(observer.navigation_succeeded());
+
+  // Ensure that we have created a new process for the subframe.
+  RenderFrameHost* foo_rfh = child->current_frame_host();
+  EXPECT_NE(shell()->web_contents()->GetMainFrame(), foo_rfh);
+  int foo_site_instance_id = foo_rfh->GetSiteInstance()->GetId();
+  EXPECT_NE(shell()->web_contents()->GetSiteInstance()->GetId(),
+            foo_site_instance_id);
+  int foo_process_id = foo_rfh->GetProcess()->GetID();
+  EXPECT_NE(shell()->web_contents()->GetRenderProcessHost()->GetID(),
+            foo_process_id);
+
+  // Load another cross-site page into the same iframe.

[Charlie Reis, 2014/03/21 23:24:33]

This second navigation tests the beforeunload crash I mentioned.

+  GURL bar_url(test_server()->GetURL("files/title1.html"));
+  replace_host.SetHostStr(bar_com);
+  bar_url = bar_url.ReplaceComponents(replace_host);
+  NavigateFrameToURL(shell()->web_contents(), child, bar_url);
+  EXPECT_EQ(bar_url, observer.navigation_url());
+  EXPECT_TRUE(observer.navigation_succeeded());
+
+  // Ensure the SiteInstance and process swapped.
+  RenderFrameHost* bar_rfh = child->current_frame_host();
+  int bar_site_instance_id = bar_rfh->GetSiteInstance()->GetId();
+  EXPECT_NE(foo_site_instance_id, bar_site_instance_id);
+  EXPECT_NE(shell()->web_contents()->GetSiteInstance()->GetId(),
+            bar_site_instance_id);
+  int bar_process_id = bar_rfh->GetProcess()->GetID();
+  EXPECT_NE(foo_process_id, bar_process_id);
+  EXPECT_NE(shell()->web_contents()->GetRenderProcessHost()->GetID(),
+            bar_process_id);
 }
 
 // Crash a subframe and ensures its children are cleared from the FrameTree.
 // See http://crbug.com/338508.
 // TODO(creis): Enable this on Android when we can kill the process there.
 #if defined(OS_ANDROID)
 #define MAYBE_CrashSubframe DISABLED_CrashSubframe
 #else
 #define MAYBE_CrashSubframe CrashSubframe
 #endif
 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, MAYBE_CrashSubframe) {
   host_resolver()->AddRule("*", "127.0.0.1");
   ASSERT_TRUE(test_server()->Start());
   GURL main_url(test_server()->GetURL("files/site_per_process_main.html"));
   NavigateToURL(shell(), main_url);
 
   StartFrameAtDataURL();
 
   // These must stay in scope with replace_host.
   GURL::Replacements replace_host;
   std::string foo_com("foo.com");
 
   // Load cross-site page into iframe.
   GURL cross_site_url(test_server()->GetURL("files/title2.html"));
   replace_host.SetHostStr(foo_com);
   cross_site_url = cross_site_url.ReplaceComponents(replace_host);
-  EXPECT_TRUE(NavigateIframeToURL(shell(), cross_site_url, "test"));
+  EXPECT_TRUE(NavigateFrameToURLInRenderer(shell(), cross_site_url, "test"));
 
   // Check the subframe process.
   FrameTreeNode* root =
       static_cast<WebContentsImpl*>(shell()->web_contents())->
           GetFrameTree()->root();
   ASSERT_EQ(1U, root->child_count());
   FrameTreeNode* child = root->child_at(0);
   EXPECT_EQ(main_url, root->current_url());
   EXPECT_EQ(cross_site_url, child->current_url());
 
@@ skipping 43 matching lines @@
   GURL https_url(https_server.GetURL("files/title1.html"));
 
   NavigateToURL(shell(), main_url);
 
   SitePerProcessWebContentsObserver observer(shell()->web_contents());
   {
     // Load cross-site client-redirect page into Iframe.
     // Should be blocked.
     GURL client_redirect_https_url(https_server.GetURL(
         "client-redirect?files/title1.html"));
-    EXPECT_TRUE(NavigateIframeToURL(shell(),
-                                    client_redirect_https_url, "test"));
+    EXPECT_TRUE(NavigateFrameToURLInRenderer(
+        shell(), client_redirect_https_url, "test"));
     // DidFailProvisionalLoad when navigating to client_redirect_https_url.
     EXPECT_EQ(observer.navigation_url(), client_redirect_https_url);
     EXPECT_FALSE(observer.navigation_succeeded());
   }
 
   {
     // Load cross-site server-redirect page into Iframe,
     // which redirects to same-site page.
     GURL server_redirect_http_url(https_server.GetURL(
         "server-redirect?" + http_url.spec()));
-    EXPECT_TRUE(NavigateIframeToURL(shell(),
-                                    server_redirect_http_url, "test"));
+    EXPECT_TRUE(NavigateFrameToURLInRenderer(
+        shell(), server_redirect_http_url, "test"));
     EXPECT_EQ(observer.navigation_url(), http_url);
     EXPECT_TRUE(observer.navigation_succeeded());
   }
 
   {
     // Load cross-site server-redirect page into Iframe,
     // which redirects to cross-site page.
     GURL server_redirect_http_url(https_server.GetURL(
         "server-redirect?files/title1.html"));
-    EXPECT_TRUE(NavigateIframeToURL(shell(),
-                                    server_redirect_http_url, "test"));
+    EXPECT_TRUE(NavigateFrameToURLInRenderer(
+        shell(), server_redirect_http_url, "test"));
     // DidFailProvisionalLoad when navigating to https_url.
     EXPECT_EQ(observer.navigation_url(), https_url);
     EXPECT_FALSE(observer.navigation_succeeded());
   }
 
   {
     // Load same-site server-redirect page into Iframe,
     // which redirects to cross-site page.
     GURL server_redirect_http_url(test_server()->GetURL(
         "server-redirect?" + https_url.spec()));
-    EXPECT_TRUE(NavigateIframeToURL(shell(),
-                                    server_redirect_http_url, "test"));
+    EXPECT_TRUE(NavigateFrameToURLInRenderer(
+        shell(), server_redirect_http_url, "test"));
 
     EXPECT_EQ(observer.navigation_url(), https_url);
     EXPECT_FALSE(observer.navigation_succeeded());
    }
 
   {
     // Load same-site client-redirect page into Iframe,
     // which redirects to cross-site page.
     GURL client_redirect_http_url(test_server()->GetURL(
         "client-redirect?" + https_url.spec()));
 
     RedirectNotificationObserver load_observer2(
         NOTIFICATION_LOAD_STOP,
         Source<NavigationController>(
             &shell()->web_contents()->GetController()));
 
-    EXPECT_TRUE(NavigateIframeToURL(shell(),
-                                    client_redirect_http_url, "test"));
+    EXPECT_TRUE(NavigateFrameToURLInRenderer(
+        shell(), client_redirect_http_url, "test"));
 
     // Same-site Client-Redirect Page should be loaded successfully.
     EXPECT_EQ(observer.navigation_url(), client_redirect_http_url);
     EXPECT_TRUE(observer.navigation_succeeded());
 
     // Redirecting to Cross-site Page should be blocked.
     load_observer2.Wait();
     EXPECT_EQ(observer.navigation_url(), https_url);
     EXPECT_FALSE(observer.navigation_succeeded());
   }
 
   {
     // Load same-site server-redirect page into Iframe,
     // which redirects to same-site page.
     GURL server_redirect_http_url(test_server()->GetURL(
         "server-redirect?files/title1.html"));
-    EXPECT_TRUE(NavigateIframeToURL(shell(),
-                                    server_redirect_http_url, "test"));
+    EXPECT_TRUE(NavigateFrameToURLInRenderer(
+        shell(), server_redirect_http_url, "test"));
     EXPECT_EQ(observer.navigation_url(), http_url);
     EXPECT_TRUE(observer.navigation_succeeded());
    }
 
   {
     // Load same-site client-redirect page into Iframe,
     // which redirects to same-site page.
     GURL client_redirect_http_url(test_server()->GetURL(
         "client-redirect?" + http_url.spec()));
     RedirectNotificationObserver load_observer2(
         NOTIFICATION_LOAD_STOP,
         Source<NavigationController>(
             &shell()->web_contents()->GetController()));
 
-    EXPECT_TRUE(NavigateIframeToURL(shell(),
-                                    client_redirect_http_url, "test"));
+    EXPECT_TRUE(NavigateFrameToURLInRenderer(
+        shell(), client_redirect_http_url, "test"));
 
     // Same-site Client-Redirect Page should be loaded successfully.
     EXPECT_EQ(observer.navigation_url(), client_redirect_http_url);
     EXPECT_TRUE(observer.navigation_succeeded());
 
     // Redirecting to Same-site Page should be loaded successfully.
     load_observer2.Wait();
     EXPECT_EQ(observer.navigation_url(), http_url);
     EXPECT_TRUE(observer.navigation_succeeded());
   }
@@ skipping 26 matching lines @@
         "client-redirect?" + http_url.spec()));
     GURL client_redirect_http_url(test_server()->GetURL(
         "client-redirect?" + client_redirect_https_url.spec()));
 
     // We should wait until second client redirect get cancelled.
     RedirectNotificationObserver load_observer2(
         NOTIFICATION_LOAD_STOP,
         Source<NavigationController>(
             &shell()->web_contents()->GetController()));
 
-    EXPECT_TRUE(NavigateIframeToURL(shell(), client_redirect_http_url, "test"));
+    EXPECT_TRUE(NavigateFrameToURLInRenderer(
+        shell(), client_redirect_http_url, "test"));
 
     // DidFailProvisionalLoad when navigating to client_redirect_https_url.
     load_observer2.Wait();
     EXPECT_EQ(observer.navigation_url(), client_redirect_https_url);
     EXPECT_FALSE(observer.navigation_succeeded());
   }
 
   {
     // Load server-redirect page pointing to a cross-site server-redirect page,
     // which eventually redirect back to same-site page.
     GURL server_redirect_https_url(https_server.GetURL(
         "server-redirect?" + http_url.spec()));
     GURL server_redirect_http_url(test_server()->GetURL(
         "server-redirect?" + server_redirect_https_url.spec()));
-    EXPECT_TRUE(NavigateIframeToURL(shell(),
-                                    server_redirect_http_url, "test"));
+    EXPECT_TRUE(NavigateFrameToURLInRenderer(
+        shell(), server_redirect_http_url, "test"));
     EXPECT_EQ(observer.navigation_url(), http_url);
     EXPECT_TRUE(observer.navigation_succeeded());
   }
 
   {
     // Load server-redirect page pointing to a cross-site server-redirect page,
     // which eventually redirects back to cross-site page.
     GURL server_redirect_https_url(https_server.GetURL(
         "server-redirect?" + https_url.spec()));
     GURL server_redirect_http_url(test_server()->GetURL(
         "server-redirect?" + server_redirect_https_url.spec()));
-    EXPECT_TRUE(NavigateIframeToURL(shell(), server_redirect_http_url, "test"));
+    EXPECT_TRUE(NavigateFrameToURLInRenderer(
+        shell(), server_redirect_http_url, "test"));
 
     // DidFailProvisionalLoad when navigating to https_url.
     EXPECT_EQ(observer.navigation_url(), https_url);
     EXPECT_FALSE(observer.navigation_succeeded());
   }
 
   {
     // Load server-redirect page pointing to a cross-site client-redirect page,
     // which eventually redirects back to same-site page.
     GURL client_redirect_http_url(https_server.GetURL(
         "client-redirect?" + http_url.spec()));
     GURL server_redirect_http_url(test_server()->GetURL(
         "server-redirect?" + client_redirect_http_url.spec()));
-    EXPECT_TRUE(NavigateIframeToURL(shell(), server_redirect_http_url, "test"));
+    EXPECT_TRUE(NavigateFrameToURLInRenderer(
+        shell(), server_redirect_http_url, "test"));
 
     // DidFailProvisionalLoad when navigating to client_redirect_http_url.
     EXPECT_EQ(observer.navigation_url(), client_redirect_http_url);
     EXPECT_FALSE(observer.navigation_succeeded());
   }
 }
 
 }  // namespace content