Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2091503003: [turbofan] Initial version of RedundancyElimination. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Initial version of RedundancyElimination. The redundancy elimination is currently a graph reducer that tries to combine redundant checks in the effect chain. It does this by propagating the checks that happened along effect paths, which is pretty similar to what the BranchElimination does on the control chain. We run this reducer together with the other optimizations right after the representation selection. An upcoming CL will extend the redundancy elimination to also eliminate redundant loads (and eventually map checks). R=jarin@chromium.org BUG=v8:5141 Committed: https://crrev.com/5250da68611dcac588b49e29f4671707bda10b14 Cr-Commit-Position: refs/heads/master@{#37208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +3 lines, -0 lines 0 comments Download
A src/compiler/redundancy-elimination.h View 1 chunk +76 lines, -0 lines 0 comments Download
A src/compiler/redundancy-elimination.cc View 1 chunk +216 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-23 08:31:17 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the baby, version 1.0. Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-06-23 08:32:18 UTC) #2
Jarin
lgtm
4 years, 6 months ago (2016-06-23 08:49:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091503003/1
4 years, 6 months ago (2016-06-23 08:49:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 08:56:53 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 08:59:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5250da68611dcac588b49e29f4671707bda10b14
Cr-Commit-Position: refs/heads/master@{#37208}

Powered by Google App Engine
This is Rietveld 408576698