Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: components/omnibox/browser/suggestion_answer.h

Issue 2091473003: Factor parsing "ln=" to SuggestionAnswer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: SuggestionAnswer::SecondLineSize -> ImageLine::TextNumLines Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/suggestion_answer.h
diff --git a/components/omnibox/browser/suggestion_answer.h b/components/omnibox/browser/suggestion_answer.h
index 8b9c04284b7153a6cbe8862855a92992444dd3a9..eb647c8325fd69751939d7dc50cb0876eb754f70 100644
--- a/components/omnibox/browser/suggestion_answer.h
+++ b/components/omnibox/browser/suggestion_answer.h
@@ -108,6 +108,7 @@ class SuggestionAnswer {
const TextField* additional_text() const { return additional_text_.get(); }
const TextField* status_text() const { return status_text_.get(); }
const GURL& image_url() const { return image_url_; }
+ int TextNumLines() const { return text_num_lines_; }
groby-ooo-7-16 2016/06/28 17:20:04 Nit: NumTextLines? Also, since it's a cheap functi
Kevin Bailey 2016/06/28 18:46:24 Done.
bool Equals(const ImageLine& line) const;
@@ -120,6 +121,7 @@ class SuggestionAnswer {
ImageLine& operator=(const ImageLine&);
TextFields text_fields_;
+ int text_num_lines_;
std::unique_ptr<TextField> additional_text_;
std::unique_ptr<TextField> status_text_;
GURL image_url_;
@@ -128,7 +130,7 @@ class SuggestionAnswer {
};
SuggestionAnswer();
- SuggestionAnswer(const SuggestionAnswer& answer);
+ SuggestionAnswer(const SuggestionAnswer& answer) = default;
~SuggestionAnswer();
// Parses |answer_json| and returns a SuggestionAnswer containing the
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_result_view.cc ('k') | components/omnibox/browser/suggestion_answer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698