chrome/browser/ui/views/omnibox/omnibox_result_view.cc - Issue 2091473003: Factor parsing "ln=" to SuggestionAnswer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_result_view.cc

Issue 2091473003: Factor parsing "ln=" to SuggestionAnswer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: SuggestionAnswer::SecondLineSize -> ImageLine::TextNumLines Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_result_view.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

index e288c4afd52bb6c5355776f9e82587101e5aa60b..b05a496e021fce46e263be34fd44dc4a17077c7a 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

@@ -290,8 +290,7 @@ gfx::Size OmniboxResultView::GetPreferredSize() const {

if (!match_.answer)

return gfx::Size(0, GetContentLineHeight());

// An answer implies a match and a description in a large font.

- const auto& text_fields = match_.answer->second_line().text_fields();

- if (text_fields.empty() || !text_fields.front().has_num_lines())

+ if (match_.answer->second_line().TextNumLines() == 1)

return gfx::Size(0, GetContentLineHeight() + GetAnswerLineHeight());

if (!description_rendertext_) {

description_rendertext_ =