Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2091453002: Enable stripping on "Mac" builder on /p/chromium waterfall (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable stripping on "Mac" builder on /p/chromium waterfall The mb config wasn't setting the 'enable_stripping' flag and was erroring out as a result after we flipped it to GN. TBR=rsesek@chromium.org NOTRY=true BUG=618468, 330301 Committed: https://crrev.com/1e235a0ebf9016b3ca88c3ebae3cf6706c5e57ec Cr-Commit-Position: refs/heads/master@{#401307}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/mb/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Dirk Pranke
NOTRY=true, TBR= since it's a (trivial) build fix.
4 years, 6 months ago (2016-06-22 16:45:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091453002/60001
4 years, 6 months ago (2016-06-22 16:46:12 UTC) #8
Robert Sesek
lgtm
4 years, 6 months ago (2016-06-22 16:47:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 6 months ago (2016-06-22 16:51:42 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 16:54:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e235a0ebf9016b3ca88c3ebae3cf6706c5e57ec
Cr-Commit-Position: refs/heads/master@{#401307}

Powered by Google App Engine
This is Rietveld 408576698