tools/mb/mb_config.pyl - Issue 2091453002: Enable stripping on "Mac" builder on /p/chromium waterfall

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/mb/mb_config.pyl

Issue 2091453002: Enable stripping on "Mac" builder on /p/chromium waterfall (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/mb/mb_config.pyl

diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl

index 180f69ab84c17acb389ead1913a4e414ca130721..9d343834f75a0002944494913691f7f1d3d005bc 100644

--- a/tools/mb/mb_config.pyl

+++ b/tools/mb/mb_config.pyl

@@ -2121,7 +2121,7 @@

'mac_strip': {

- 'gn_args': 'error', # TODO(GYP): Port mac_strip_release

+ 'gn_args': 'enable_stripping=true',

'gyp_defines': 'mac_strip_release=1',

« no previous file with comments | « no previous file | no next file » | no next file with comments »