chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h - Issue 2091353002: Generalize the reload PLMO to support other transition types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

Issue 2091353002: Generalize the reload PLMO to support other transition types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add abort unit tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc » ('j') | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

index 1bae6eb4f0f9dc3813c00fd1f548d7e0e63b40d6..81c6b06c0c7ad06ae2f708fe5b831faaf76b9776 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

@@ -32,6 +32,10 @@ extern const char kBackgroundHistogramDomContentLoaded[];

extern const char kBackgroundHistogramLoad[];

extern const char kBackgroundHistogramFirstPaint[];

+extern const char kHistogramLoadTypeFirstContentfulPaintReload[];

+extern const char kHistogramLoadTypeFirstContentfulPaintForwardBack[];

+extern const char kHistogramLoadTypeFirstContentfulPaintNewNavigation[];

extern const char kHistogramBackgroundBeforePaint[];

extern const char kHistogramFailedProvisionalLoad[];

@@ -49,6 +53,7 @@ class CorePageLoadMetricsObserver

~CorePageLoadMetricsObserver() override;

// page_load_metrics::PageLoadMetricsObserver:

+ void OnCommit(content::NavigationHandle* navigation_handle) override;

void OnDomContentLoadedEventStart(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& extra_info) override;

@@ -98,6 +103,8 @@ class CorePageLoadMetricsObserver

const page_load_metrics::PageLoadExtraInfo& info);

FailedProvisionalLoadInfo failed_provisional_load_info_;

+ ui::PageTransition transition_;

+ bool initiated_by_user_gesture_;

DISALLOW_COPY_AND_ASSIGN(CorePageLoadMetricsObserver);

};