Generalize the reload PLMO to support other transition types.

chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc

Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
index 9fba965a69108d77b6aa11ba2777694c048b3120..3557d722926ec92f20a532e3c0e7ee9ddbec1b57 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
@@ -36,6 +36,40 @@ TEST_F(AbortsPageLoadMetricsObserverTest, NewNavigationBeforePaint) {
   NavigateAndCommit(GURL("https://www.example.com"));
   histogram_tester().ExpectTotalCount(
       internal::kHistogramAbortNewNavigationBeforePaint, 1);
+  histogram_tester().ExpectTotalCount(
+      internal::kHistogramAbortReloadBeforePaint, 0);
+  histogram_tester().ExpectTotalCount(
+      internal::kHistogramAbortForwardBackBeforePaint, 0);
+}
+
+TEST_F(AbortsPageLoadMetricsObserverTest, ReloadBeforePaint) {
+  NavigateAndCommit(GURL("https://www.example.com"));
+  SimulateTimingWithoutPaint();
+  // Simulate the user performing a reload navigation before paint.
+  NavigateWithPageTransitionAndCommit(GURL("https://www.google.com"),
+                                      ui::PAGE_TRANSITION_RELOAD);
+  histogram_tester().ExpectTotalCount(
+      internal::kHistogramAbortReloadBeforePaint, 1);
+  histogram_tester().ExpectTotalCount(
+      internal::kHistogramAbortNewNavigationBeforePaint, 0);
+  histogram_tester().ExpectTotalCount(
+      internal::kHistogramAbortForwardBackBeforePaint, 0);
+}
+
+TEST_F(AbortsPageLoadMetricsObserverTest, ForwardBackBeforePaint) {
+  NavigateAndCommit(GURL("https://www.example.com"));
+  SimulateTimingWithoutPaint();
+  // Simulate the user performing a forward/back navigation before paint.
+  NavigateWithPageTransitionAndCommit(
+      GURL("https://www.google.com"),
+      ui::PageTransitionFromInt(ui::PAGE_TRANSITION_TYPED |
+                                ui::PAGE_TRANSITION_FORWARD_BACK));
+  histogram_tester().ExpectTotalCount(
+      internal::kHistogramAbortForwardBackBeforePaint, 1);
+  histogram_tester().ExpectTotalCount(
+      internal::kHistogramAbortNewNavigationBeforePaint, 0);
+  histogram_tester().ExpectTotalCount(
+      internal::kHistogramAbortReloadBeforePaint, 0);
 }
 
 TEST_F(AbortsPageLoadMetricsObserverTest, StopBeforeCommit) {
@@ -125,8 +159,6 @@ TEST_F(AbortsPageLoadMetricsObserverTest,
                                       1);
 }
 
-// TODO(bmcquade): add tests for reload, back/forward, and other aborts.
-
 TEST_F(AbortsPageLoadMetricsObserverTest, NoAbortNewNavigationFromAboutURL) {
   NavigateAndCommit(GURL("about:blank"));
   NavigateAndCommit(GURL("https://www.example.com"));