Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2091213003: ARC: Fix wrong minimum version for showPackageInfoOnPage. (Closed)

Created:
4 years, 6 months ago by mtomasz
Modified:
4 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, tapted, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, Matt Giuca
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ARC: Fix wrong minimum version for showPackageInfoOnPage. Due to rebasing hell. TBR=pkasting BUG=621399 Committed: https://crrev.com/066ca368a211cfb6b7e73dbb9aacfa31bd442093 Cr-Commit-Position: refs/heads/master@{#401805}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
mtomasz
@pkasting: PTAL (TBR). Thanks.
4 years, 6 months ago (2016-06-24 02:23:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091213003/1
4 years, 6 months ago (2016-06-24 02:24:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 03:16:48 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/066ca368a211cfb6b7e73dbb9aacfa31bd442093 Cr-Commit-Position: refs/heads/master@{#401805}
4 years, 6 months ago (2016-06-24 03:20:21 UTC) #10
Peter Kasting
4 years, 5 months ago (2016-06-29 21:40:11 UTC) #11
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698