Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: chrome/browser/ui/app_list/arc/arc_app_utils.cc

Issue 2091213003: ARC: Fix wrong minimum version for showPackageInfoOnPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/app_list/arc/arc_app_utils.h" 5 #include "chrome/browser/ui/app_list/arc/arc_app_utils.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "ash/shell.h" 9 #include "ash/shell.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 15 matching lines...) Expand all
26 constexpr int kNexus7Height = 600; 26 constexpr int kNexus7Height = 600;
27 constexpr int kNexus5Width = 410; 27 constexpr int kNexus5Width = 410;
28 constexpr int kNexus5Height = 690; 28 constexpr int kNexus5Height = 690;
29 29
30 // Minimum required versions. 30 // Minimum required versions.
31 constexpr int kMinVersion = 0; 31 constexpr int kMinVersion = 0;
32 constexpr int kCanHandleResolutionMinVersion = 1; 32 constexpr int kCanHandleResolutionMinVersion = 1;
33 constexpr int kUninstallPackageMinVersion = 2; 33 constexpr int kUninstallPackageMinVersion = 2;
34 constexpr int kShowPackageInfoMinVersion = 5; 34 constexpr int kShowPackageInfoMinVersion = 5;
35 constexpr int kRemoveIconMinVersion = 9; 35 constexpr int kRemoveIconMinVersion = 9;
36 constexpr int kShowPackageInfoOnPageMinVersion = 11; 36 constexpr int kShowPackageInfoOnPageMinVersion = 10;
37 37
38 // Service name strings. 38 // Service name strings.
39 constexpr char kCanHandleResolutionStr[] = "get resolution capability"; 39 constexpr char kCanHandleResolutionStr[] = "get resolution capability";
40 constexpr char kLaunchAppStr[] = "launch app"; 40 constexpr char kLaunchAppStr[] = "launch app";
41 constexpr char kShowPackageInfoStr[] = "show package info"; 41 constexpr char kShowPackageInfoStr[] = "show package info";
42 constexpr char kUninstallPackageStr[] = "uninstall package"; 42 constexpr char kUninstallPackageStr[] = "uninstall package";
43 constexpr char kRemoveIconStr[] = "remove icon"; 43 constexpr char kRemoveIconStr[] = "remove icon";
44 44
45 // Helper function which returns the AppInstance. Create related logs when error 45 // Helper function which returns the AppInstance. Create related logs when error
46 // happens. 46 // happens.
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 if (!app_instance) 298 if (!app_instance)
299 return false; 299 return false;
300 300
301 app_instance->ShowPackageInfoOnPage( 301 app_instance->ShowPackageInfoOnPage(
302 package_name, page, 302 package_name, page,
303 GetTargetRect(gfx::Size(kNexus7Width, kNexus7Height))); 303 GetTargetRect(gfx::Size(kNexus7Width, kNexus7Height)));
304 return true; 304 return true;
305 } 305 }
306 306
307 } // namespace arc 307 } // namespace arc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698