Add CheckOCSPDateValid() to net/cert/internal

net/cert/internal/parse_ocsp_unittest.cc

Index: net/cert/internal/parse_ocsp_unittest.cc
diff --git a/net/cert/internal/parse_ocsp_unittest.cc b/net/cert/internal/parse_ocsp_unittest.cc
index c0fc061b5e43243f39d156444df42a61f38915e5..44d1cb13c350cb502fcc1d63fff7a39f2d8464a4 100644
--- a/net/cert/internal/parse_ocsp_unittest.cc
+++ b/net/cert/internal/parse_ocsp_unittest.cc
@@ -15,6 +15,8 @@ namespace net {
 
 namespace {
 
+const base::TimeDelta kOCSPAgeOneWeek = base::TimeDelta::FromDays(7);
+
 std::string GetFilePath(const std::string& file_name) {
   return std::string("net/data/parse_ocsp_unittest/") + file_name;
 }
@@ -182,4 +184,69 @@ TEST(ParseOCSPTest, OCSPMissingResponse) {
   ASSERT_EQ(PARSE_OCSP_SINGLE_RESPONSE, ParseOCSP("missing_response.pem"));
 }
 
+TEST(OCSPDateTest, Valid) {
+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time this_update = now - base::TimeDelta::FromHours(1);
+  base::Time next_update = this_update + base::TimeDelta::FromDays(7);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_TRUE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_TRUE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
+TEST(OCSPDateTest, Young) {
+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time this_update = now + base::TimeDelta::FromHours(1);
+  base::Time next_update = this_update + base::TimeDelta::FromDays(7);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
+TEST(OCSPDateTest, Old) {
+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time this_update = now - base::TimeDelta::FromDays(6);
+  base::Time next_update = now - base::TimeDelta::FromHours(1);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_TRUE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
+TEST(OCSPDateTest, Backwards) {

[Ryan Sleevi, 2016/06/28 17:33:30]

What is backwards?

[dadrian, 2016/06/29 22:54:02]

Done.

+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time next_update = now - base::TimeDelta::FromHours(1);
+  base::Time this_update = next_update + base::TimeDelta::FromDays(7);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
+TEST(OCSPDateTest, Long) {

[Ryan Sleevi, 2016/06/28 17:33:30]

What is long?

[dadrian, 2016/06/29 22:54:02]

Done.

+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time this_update = now - base::TimeDelta::FromDays(365);
+  base::Time next_update = now + base::TimeDelta::FromHours(1);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
 }  // namespace net