Add CheckOCSPDateValid() to net/cert/internal

net/der/parse_values.h

Index: net/der/parse_values.h
diff --git a/net/der/parse_values.h b/net/der/parse_values.h
index 161b098ecbe08f314e5fcc5508f04a6b7c143cb6..117908e25fa85727cc3b30aace11d977c2c98370 100644
--- a/net/der/parse_values.h
+++ b/net/der/parse_values.h
@@ -11,6 +11,10 @@
 #include "net/base/net_export.h"
 #include "net/der/input.h"
 
+namespace base {
+class Time;
+}
+
 namespace net {
 
 namespace der {
@@ -125,6 +129,10 @@ NET_EXPORT bool ParseUTCTimeRelaxed(const Input& in,
 NET_EXPORT bool ParseGeneralizedTime(const Input& in,
                                      GeneralizedTime* out) WARN_UNUSED_RESULT;
 
+// Encodes |time|, a UTC-based time, to DER, for comparing against other
+// GeneralizedTime objects.
+NET_EXPORT der::GeneralizedTime ConvertBaseUTCTime(const base::Time& time);

[Ryan Sleevi, 2016/06/28 17:33:30]

NAMING: This naming doesn't really help understand what this code does...
"ConvertBaseUTCTime" - is it converting timezones? What's it converting to?

This is really:

EncodeTimeAsGeneralizedTime(...)

right?

Does this really belong in parse_values? Isn't this an encoding property?

[dadrian, 2016/06/28 19:15:27]

I'm happy to move this function somewhere else, but offhand I don't know a
better location.

[Ryan Sleevi, 2016/06/28 19:26:44]

net/der/encode_values.h ?

[dadrian, 2016/06/29 22:54:02]

Done.

+
 }  // namespace der
 
 }  // namespace net