Add CheckOCSPDateValid() to net/cert/internal

net/cert/internal/parse_ocsp_unittest.cc

Index: net/cert/internal/parse_ocsp_unittest.cc
diff --git a/net/cert/internal/parse_ocsp_unittest.cc b/net/cert/internal/parse_ocsp_unittest.cc
index c0fc061b5e43243f39d156444df42a61f38915e5..881e9f4c06c983084770d88e07265bd0081a3514 100644
--- a/net/cert/internal/parse_ocsp_unittest.cc
+++ b/net/cert/internal/parse_ocsp_unittest.cc
@@ -182,4 +182,71 @@ TEST(ParseOCSPTest, OCSPMissingResponse) {
   ASSERT_EQ(PARSE_OCSP_SINGLE_RESPONSE, ParseOCSP("missing_response.pem"));
 }
 
+const base::TimeDelta kOCSPAgeOneWeek = base::TimeDelta::FromDays(7);

[estark, 2016/06/24 00:27:35]

this could go in the anonymous namespace

[dadrian, 2016/06/24 01:41:52]

Done.

+
+TEST(OCSPDateTest, Valid) {
+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time this_update = now - base::TimeDelta::FromHours(1);
+  base::Time next_update = this_update + base::TimeDelta::FromDays(7);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_TRUE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_TRUE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
+TEST(OCSPDateTest, Young) {
+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time this_update = now + base::TimeDelta::FromHours(1);
+  base::Time next_update = this_update + base::TimeDelta::FromDays(7);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
+TEST(OCSPDateTest, Old) {
+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time this_update = now - base::TimeDelta::FromDays(6);
+  base::Time next_update = now - base::TimeDelta::FromHours(1);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_TRUE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
+TEST(OCSPDateTest, Backwards) {
+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time next_update = now - base::TimeDelta::FromHours(1);
+  base::Time this_update = next_update + base::TimeDelta::FromDays(7);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
+TEST(OCSPDateTest, Long) {
+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time this_update = now - base::TimeDelta::FromDays(365);
+  base::Time next_update = now + base::TimeDelta::FromHours(1);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
 }  // namespace net