Add CheckOCSPDateValid() to net/cert/internal

net/cert/internal/parse_ocsp_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/internal/parse_ocsp.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "net/cert/internal/test_helpers.h"
 #include "net/cert/x509_certificate.h"
@@ skipping 164 matching lines @@
 }
 
 TEST(ParseOCSPTest, OCSPOCSPSingleExtension) {
   ASSERT_EQ(OCSP_SUCCESS, ParseOCSP("has_single_extension.pem"));
 }
 
 TEST(ParseOCSPTest, OCSPMissingResponse) {
   ASSERT_EQ(PARSE_OCSP_SINGLE_RESPONSE, ParseOCSP("missing_response.pem"));
 }
 
+const base::TimeDelta kOCSPAgeOneWeek = base::TimeDelta::FromDays(7);

[estark, 2016/06/24 00:27:35]

this could go in the anonymous namespace

[dadrian, 2016/06/24 01:41:52]

Done.

+
+TEST(OCSPDateTest, Valid) {
+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time this_update = now - base::TimeDelta::FromHours(1);
+  base::Time next_update = this_update + base::TimeDelta::FromDays(7);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_TRUE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_TRUE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
+TEST(OCSPDateTest, Young) {
+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time this_update = now + base::TimeDelta::FromHours(1);
+  base::Time next_update = this_update + base::TimeDelta::FromDays(7);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
+TEST(OCSPDateTest, Old) {
+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time this_update = now - base::TimeDelta::FromDays(6);
+  base::Time next_update = now - base::TimeDelta::FromHours(1);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_TRUE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
+TEST(OCSPDateTest, Backwards) {
+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time next_update = now - base::TimeDelta::FromHours(1);
+  base::Time this_update = next_update + base::TimeDelta::FromDays(7);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
+TEST(OCSPDateTest, Long) {
+  OCSPSingleResponse response;
+  base::Time now = base::Time::Now();
+  base::Time this_update = now - base::TimeDelta::FromDays(365);
+  base::Time next_update = now + base::TimeDelta::FromHours(1);
+  response.this_update = der::ConvertBaseUTCTime(this_update);
+  response.has_next_update = false;
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+  response.has_next_update = true;
+  response.next_update = der::ConvertBaseUTCTime(next_update);
+  EXPECT_FALSE(CheckOCSPDateValid(response, now, kOCSPAgeOneWeek));
+}
+
 }  // namespace net