Correct the flag: is_extension_upgrade, which denote whether the extension is being upgrading.

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 5829a47b5f8c0f6e947b7878ecd302e859cced62..b5baa2ebf9426d0b90852e1b8d50efd00b45ee51 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1997,12 +1997,14 @@ void ExtensionService::AddExtension(const Extension* extension) {
 
   bool is_extension_upgrade = false;
   if (const Extension* old = GetInstalledExtension(extension->id())) {
-    is_extension_upgrade = true;
     DCHECK_NE(extension, old);
     // Other than for unpacked extensions, CrxInstaller should have guaranteed
     // that we aren't downgrading.
-    if (!Manifest::IsUnpackedLocation(extension->location()))
+    if (!Manifest::IsUnpackedLocation(extension->location())) {
       CHECK_GE(extension->version()->CompareTo(*(old->version())), 0);
+      is_extension_upgrade =
+          extension->version()->CompareTo(*(old->version())) > 0;
+    }

[asargent_no_longer_on_chrome, 2013/07/29 23:09:01]

I think this block would read a little better written as follows:


bool is_extension_upgrade = false;
const Extension* old = GetInstalledExtension(extension->id())) {
if (old) {
  DCHECK_NE(extension, old);
  is_extension_upgrade =
    (extension->version()->CompareTo(*(old->version())) > 0);
  // Other than for unpacked extensions, CrxInstaller should have guaranteed
  // that we aren't downgrading.
  if (!Manifest::IsUnpackedLocation(extension->location())) {
    CHECK(is_extension_upgrade);
  }
}

[zhchbin, 2013/07/30 01:46:41]

Note that here is *CHECK_GE*. And is_extension_upgrade should be true only when
the result of CompareTo greater than 0. The function AddExtension will be called
when reloading the extension, there are many situation need to involve it. For
example, extension upgrading, reload a crashed extension, reload an unpacked
app/extension, etc.

   }
   SetBeingUpgraded(extension, is_extension_upgrade);