Correct the flag: is_extension_upgrade, which denote whether the extension is being upgrading.

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <iterator>
 #include <set>
 
@@ skipping 1979 matching lines @@
   // is set (http://crbug.com/29067).
   if (!extensions_enabled() &&
       !extension->is_theme() &&
       extension->location() != Manifest::COMPONENT &&
       !Manifest::IsExternalLocation(extension->location())) {
     return;
   }
 
   bool is_extension_upgrade = false;
   if (const Extension* old = GetInstalledExtension(extension->id())) {
-    is_extension_upgrade = true;
     DCHECK_NE(extension, old);
     // Other than for unpacked extensions, CrxInstaller should have guaranteed
     // that we aren't downgrading.
-    if (!Manifest::IsUnpackedLocation(extension->location()))
+    if (!Manifest::IsUnpackedLocation(extension->location())) {
       CHECK_GE(extension->version()->CompareTo(*(old->version())), 0);
+      is_extension_upgrade =
+          extension->version()->CompareTo(*(old->version())) > 0;
+    }

[asargent_no_longer_on_chrome, 2013/07/29 23:09:01]

I think this block would read a little better written as follows:


bool is_extension_upgrade = false;
const Extension* old = GetInstalledExtension(extension->id())) {
if (old) {
  DCHECK_NE(extension, old);
  is_extension_upgrade =
    (extension->version()->CompareTo(*(old->version())) > 0);
  // Other than for unpacked extensions, CrxInstaller should have guaranteed
  // that we aren't downgrading.
  if (!Manifest::IsUnpackedLocation(extension->location())) {
    CHECK(is_extension_upgrade);
  }
}

[zhchbin, 2013/07/30 01:46:41]

Note that here is *CHECK_GE*. And is_extension_upgrade should be true only when
the result of CompareTo greater than 0. The function AddExtension will be called
when reloading the extension, there are many situation need to involve it. For
example, extension upgrading, reload a crashed extension, reload an unpacked
app/extension, etc.

   }
   SetBeingUpgraded(extension, is_extension_upgrade);
 
   // The extension is now loaded, remove its data from unloaded extension map.
   unloaded_extension_paths_.erase(extension->id());
 
   // If a terminated extension is loaded, remove it from the terminated list.
   UntrackTerminatedExtension(extension->id());
 
   // If the extension was disabled for a reload, then enable it.
@@ skipping 1054 matching lines @@
 }
 
 void ExtensionService::AddUpdateObserver(extensions::UpdateObserver* observer) {
   update_observers_.AddObserver(observer);
 }
 
 void ExtensionService::RemoveUpdateObserver(
     extensions::UpdateObserver* observer) {
   update_observers_.RemoveObserver(observer);
 }