Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2090873002: Reland of [Chromoting] Disable building 64bit chromoting.msi file. (Closed)

Created:
4 years, 6 months ago by Hzj_jie
Modified:
4 years, 5 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, Jamie, dimu, govind
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [Chromoting] Disable building 64bit chromoting.msi file. (patchset #1 id:1 of https://codereview.chromium.org/2088363002/ ) Reason for revert: Try to reproduce the build break. Original issue's description: > Revert of [Chromoting] Disable building 64bit chromoting.msi file. (patchset #2 id:60001 of https://codereview.chromium.org/2073943002/ ) > > Reason for revert: > Breaks the build: https://bugs.chromium.org/p/chromium/issues/detail?id=622443 > > Original issue's description: > > [Chromoting] Disable building 64bit chromoting.msi file. > > > > A recent bug http://crbug.com/613001 has been reported by AJ, which is due to a > > bad signing parameter we are using. It causes the 64 bit signed MSI file won't > > be able to execute correctly in curtain mode. > > Since we do not release 64bit msi, we should not spend time to build it. > > > > BUG= > > > > Committed: https://crrev.com/b4ed437b70ea66dc21fc7aaf856d9524e24a02b3 > > Cr-Commit-Position: refs/heads/master@{#401031} > > TBR=joedow@chromium.org,zijiehe@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= > NOTRY=true > > Committed: https://crrev.com/10868cf662bacfbb13b376c8baf3858ea7286528 > Cr-Commit-Position: refs/heads/master@{#401487} TBR=joedow@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/7577d9edf001de94942d78b6fa90c68c9678a7c2 Cr-Commit-Position: refs/heads/master@{#402315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -24 lines) Patch
M remoting/host/BUILD.gn View 1 chunk +26 lines, -23 lines 0 comments Download
M remoting/remoting_host_win.gypi View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Hzj_jie
Created Reland of [Chromoting] Disable building 64bit chromoting.msi file.
4 years, 6 months ago (2016-06-23 01:13:13 UTC) #1
Michael Moss
This is also breaking the official win64 build because this expected file (https://chromium.googlesource.com/chromium/src.git/+/master/chrome/tools/build/win/FILES.cfg#396) is now ...
4 years, 6 months ago (2016-06-23 13:14:44 UTC) #3
Hzj_jie
On 2016/06/23 13:14:44, Michael Moss wrote: > This is also breaking the official win64 build ...
4 years, 6 months ago (2016-06-23 18:00:33 UTC) #4
Hzj_jie
On 2016/06/23 18:00:33, Hzj_jie wrote: > On 2016/06/23 13:14:44, Michael Moss wrote: > > This ...
4 years, 6 months ago (2016-06-23 20:09:46 UTC) #5
Michael Moss
On 2016/06/23 20:09:46, Hzj_jie wrote: > On 2016/06/23 18:00:33, Hzj_jie wrote: > > On 2016/06/23 ...
4 years, 6 months ago (2016-06-24 18:09:36 UTC) #6
joedow
lgtm
4 years, 5 months ago (2016-06-27 17:10:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2090873002/1
4 years, 5 months ago (2016-06-27 22:28:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 22:29:30 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 22:31:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7577d9edf001de94942d78b6fa90c68c9678a7c2
Cr-Commit-Position: refs/heads/master@{#402315}

Powered by Google App Engine
This is Rietveld 408576698