[Chromoting] Disable building 64bit chromoting.msi file.

[Chromoting] Disable building 64bit chromoting.msi file.

A recent bug http://crbug.com/613001 has been reported by AJ, which is due to a
bad signing parameter we are using. It causes the 64 bit signed MSI file won't
be able to execute correctly in curtain mode.
Since we do not release 64bit msi, we should not spend time to build it.

BUG=

Committed: https://crrev.com/b4ed437b70ea66dc21fc7aaf856d9524e24a02b3
Cr-Commit-Position: refs/heads/master@{#401031}

[Hzj_jie, 2016-06-17 00:49:27]

Description was changed from

==========
[Chromoting] Disable building 64bit chromoting.msi file.

A recent bug crbug.com/613001 has been reported by AJ, and it's due to a bad
signing parameter we are using. It causes the 64 bit signed MSI file won't be
able to execute correctly in curtain mode.
Since we do not release 64bit msi, we should not spend time to build it.

BUG=
==========

to

==========
[Chromoting] Disable building 64bit chromoting.msi file.

A recent bug http://crbug.com/613001 has been reported by AJ, which is due to a
bad signing parameter we are using. It causes the 64 bit signed MSI file won't
be able to execute correctly in curtain mode.
Since we do not release 64bit msi, we should not spend time to build it.

BUG=
==========

[Hzj_jie, 2016-06-19 20:47:29]

Patchset #1 (id:1) has been deleted

[Hzj_jie, 2016-06-19 20:57:50]

Patchset #1 (id:20001) has been deleted

[Hzj_jie, 2016-06-19 22:09:08]

zijiehe@chromium.org changed reviewers:
+ joedow@chromium.org

[Hzj_jie, 2016-06-19 22:09:47]

Also copy Jamie for the decision.

[joedow, 2016-06-20 22:15:04]

https://codereview.chromium.org/2073943002/diff/40001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/2073943002/diff/40001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:1150: 
I think adding a comment would be good on why we only build this target for x86.

https://codereview.chromium.org/2073943002/diff/40001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:1173: group("remoting_host_installation") {
Is this empty target needed?  The GYP change just removes the target for x64,
why is there an empty one here for GN?

https://codereview.chromium.org/2073943002/diff/40001/remoting/remoting_host_...
File remoting/remoting_host_win.gypi (right):

https://codereview.chromium.org/2073943002/diff/40001/remoting/remoting_host_...
remoting/remoting_host_win.gypi:566: ['wix_exists == "True" and target_arch ==
"ia32"', {
nit: Add comment on why we don't build for x64.

[Hzj_jie, 2016-06-21 02:14:56]

https://codereview.chromium.org/2073943002/diff/40001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/2073943002/diff/40001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:1150: 
On 2016/06/20 22:15:04, joedow wrote:
> I think adding a comment would be good on why we only build this target for
x86.

Done.

https://codereview.chromium.org/2073943002/diff/40001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:1173: group("remoting_host_installation") {
On 2016/06/20 22:15:04, joedow wrote:
> Is this empty target needed?  The GYP change just removes the target for x64,
> why is there an empty one here for GN?

In GYP, the default empty target has already been added.

https://codereview.chromium.org/2073943002/diff/40001/remoting/remoting_host_...
File remoting/remoting_host_win.gypi (right):

https://codereview.chromium.org/2073943002/diff/40001/remoting/remoting_host_...
remoting/remoting_host_win.gypi:566: ['wix_exists == "True" and target_arch ==
"ia32"', {
On 2016/06/20 22:15:04, joedow wrote:
> nit: Add comment on why we don't build for x64.

Done.

[joedow, 2016-06-21 02:52:26]

lgtm

[Hzj_jie, 2016-06-21 17:33:02]

The CQ bit was checked by zijiehe@chromium.org

[commit-bot: I haz the power, 2016-06-21 17:33:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073943002/60001

[commit-bot: I haz the power, 2016-06-21 17:40:13]

Description was changed from

==========
[Chromoting] Disable building 64bit chromoting.msi file.

A recent bug http://crbug.com/613001 has been reported by AJ, which is due to a
bad signing parameter we are using. It causes the 64 bit signed MSI file won't
be able to execute correctly in curtain mode.
Since we do not release 64bit msi, we should not spend time to build it.

BUG=
==========

to

==========
[Chromoting] Disable building 64bit chromoting.msi file.

A recent bug http://crbug.com/613001 has been reported by AJ, which is due to a
bad signing parameter we are using. It causes the 64 bit signed MSI file won't
be able to execute correctly in curtain mode.
Since we do not release 64bit msi, we should not spend time to build it.

BUG=
==========

[commit-bot: I haz the power, 2016-06-21 17:40:14]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-06-21 17:49:56]

Description was changed from

==========
[Chromoting] Disable building 64bit chromoting.msi file.

A recent bug http://crbug.com/613001 has been reported by AJ, which is due to a
bad signing parameter we are using. It causes the 64 bit signed MSI file won't
be able to execute correctly in curtain mode.
Since we do not release 64bit msi, we should not spend time to build it.

BUG=
==========

to

==========
[Chromoting] Disable building 64bit chromoting.msi file.

A recent bug http://crbug.com/613001 has been reported by AJ, which is due to a
bad signing parameter we are using. It causes the 64 bit signed MSI file won't
be able to execute correctly in curtain mode.
Since we do not release 64bit msi, we should not spend time to build it.

BUG=

Committed: https://crrev.com/b4ed437b70ea66dc21fc7aaf856d9524e24a02b3
Cr-Commit-Position: refs/heads/master@{#401031}
==========

[commit-bot: I haz the power, 2016-06-21 17:49:57]

Patchset 2 (id:??) landed as
https://crrev.com/b4ed437b70ea66dc21fc7aaf856d9524e24a02b3
Cr-Commit-Position: refs/heads/master@{#401031}

[dgozman, 2016-06-23 00:16:55]

A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.chromium.org/2088363002/ by dgozman@chromium.org.

The reason for reverting is: Breaks the build:
https://bugs.chromium.org/p/chromium/issues/detail?id=622443.