[OriginTrials] Raise an exception at compile time for OT-enabled methods

[OriginTrials] Raise an exception at compile time for OT-enabled methods

We don't currently support origin trials on individual methods (methods which
are part of an origin-trial-enabled attribute are supported), and the
generated bindings code for these is incorrect. This patch causes an
exception to be raised at compile time to ensure that noone tries to add
the OriginTrialEnabled attribute to a method.

This also prevents trials from being defined on:
 - Iterators
 - Maplike and Setlike methods
 - Stringifiers and Serializers

As part of this patch, the methods defined in TestObject.idl which were
generating incorrect code have been commented out.

BUG=621641
R=chasej@chromium.org, haraken@chromium.org

Committed: https://crrev.com/0fa26a48c0341e8676aaafc1f33fc825d3581709
Cr-Commit-Position: refs/heads/master@{#401945}

[iclelland, 2016-06-24 03:55:22]

+r chasej, haraken -- can you PTAL? Thanks.

I believe that this captures most of the unsupported features with origin trials
in IDL, and raises exceptions if someone tries to use them.

I intend to relax these restrictions, and move the exception to more specific
unsupported cases as the origin trials bindings code gains more features.

[haraken, 2016-06-24 03:58:37]

LGTM

It would be great if you clarify what's supported and what's not in
IDLExtendedAttributes.md.

[iclelland, 2016-06-24 04:21:28]

On 2016/06/24 03:58:37, haraken wrote:
> LGTM
> 
> It would be great if you clarify what's supported and what's not in
> IDLExtendedAttributes.md.

Thanks! Does the note in the latest patch make it clear enough? (And clear that
it's a bug, that we actually *do* want to support this)

[haraken, 2016-06-24 04:22:23]

LGTM

[chasej, 2016-06-24 18:08:13]

LGTM.

[iclelland, 2016-06-24 18:31:21]

The CQ bit was checked by iclelland@chromium.org

[commit-bot: I haz the power, 2016-06-24 18:32:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 20:09:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-24 20:11:02]

Description was changed from

==========
[OriginTrials] Raise an exception at compile time for OT-enabled methods

We don't currently support origin trials on individual methods (methods which
are part of an origin-trial-enabled attribute are supported), and the
generated bindings code for these is incorrect. This patch causes an
exception to be raised at compile time to ensure that noone tries to add
the OriginTrialEnabled attribute to a method.

This also prevents trials from being defined on:
 - Iterators
 - Maplike and Setlike methods
 - Stringifiers and Serializers

As part of this patch, the methods defined in TestObject.idl which were
generating incorrect code have been commented out.

BUG=621641
R=chasej@chromium.org, haraken@chromium.org
==========

to

==========
[OriginTrials] Raise an exception at compile time for OT-enabled methods

We don't currently support origin trials on individual methods (methods which
are part of an origin-trial-enabled attribute are supported), and the
generated bindings code for these is incorrect. This patch causes an
exception to be raised at compile time to ensure that noone tries to add
the OriginTrialEnabled attribute to a method.

This also prevents trials from being defined on:
 - Iterators
 - Maplike and Setlike methods
 - Stringifiers and Serializers

As part of this patch, the methods defined in TestObject.idl which were
generating incorrect code have been commented out.

BUG=621641
R=chasej@chromium.org, haraken@chromium.org

Committed: https://crrev.com/0fa26a48c0341e8676aaafc1f33fc825d3581709
Cr-Commit-Position: refs/heads/master@{#401945}
==========

[commit-bot: I haz the power, 2016-06-24 20:11:04]

Patchset 2 (id:??) landed as
https://crrev.com/0fa26a48c0341e8676aaafc1f33fc825d3581709
Cr-Commit-Position: refs/heads/master@{#401945}