third_party/WebKit/Source/bindings/scripts/v8_methods.py - Issue 2090773005: [OriginTrials] Raise an exception at compile time for OT-enabled methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_methods.py

Issue 2090773005: [OriginTrials] Raise an exception at compile time for OT-enabled methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add note about support in IDLExtendedAttributes.md Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/IDLExtendedAttributes.md ('k') | third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_methods.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_methods.py b/third_party/WebKit/Source/bindings/scripts/v8_methods.py

index a2f12e4120679c3de74bc21b148cbb439c6c3987..f79f6ea0ac30c4139a2dd6210f30547185f9305c 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_methods.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_methods.py

@@ -68,6 +68,13 @@ def method_context(interface, method, is_visible=True):

is_static = method.is_static

name = method.name

+ # [OriginTrialEnabled]

+ # TODO(iclelland): Allow origin trials on methods

+ # (crbug.com/621641)

+ if v8_utilities.origin_trial_feature_name(method):

+ raise Exception('[OriginTrialEnabled] cannot be specified on '

+ 'individual methods: %s.%s' % (interface.name, method.name))

if is_visible:

idl_type.add_includes_for_type(extended_attributes)