Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2090653003: Ignore IPC security check on deleted files (Closed)

Created:
4 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, dcheng
CC:
Anand Mistry (off Chromium), chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore IPC security check on deleted files If a file has been deleted, don't bother adding its OWNERS file to the set of files to be checked for correct security lines. BUG=622569 Committed: https://crrev.com/5124933c736ff0ac907a1b051e8dac83d3f9bc06 Cr-Commit-Position: refs/heads/master@{#401625}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Ken Rockot(use gerrit already)
Please take a look
4 years, 6 months ago (2016-06-23 04:42:34 UTC) #3
dcheng
lgtm
4 years, 6 months ago (2016-06-23 08:30:13 UTC) #7
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-23 16:25:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090653003/60001
4 years, 6 months ago (2016-06-23 16:27:38 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 6 months ago (2016-06-23 16:32:44 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 16:35:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5124933c736ff0ac907a1b051e8dac83d3f9bc06
Cr-Commit-Position: refs/heads/master@{#401625}

Powered by Google App Engine
This is Rietveld 408576698