PRESUBMIT.py - Issue 2090653003: Ignore IPC security check on deleted files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2090653003: Ignore IPC security check on deleted files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 61301616d7939a1ed1f31188ff157c192bafc95a..134f62dea44f8d3f034aff7d6d7d4cae9e9e3f94 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -1447,7 +1447,7 @@ def _CheckIpcOwners(input_api, output_api):

# directory would match that pattern. If a directory only contains *.mojom

# files and no *_messages*.h files, we should only nag about rules for

# *.mojom files.

- for f in input_api.change.AffectedFiles():

+ for f in input_api.change.AffectedFiles(include_deletes=False):

for pattern in file_patterns:

if input_api.fnmatch.fnmatch(

input_api.os_path.basename(f.LocalPath()), pattern):

« no previous file with comments | « no previous file | no next file » | no next file with comments »