Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2090353005: Revert of tabing inconsistencies between trays in status area (Closed)

Created:
4 years, 6 months ago by falken
Modified:
4 years, 6 months ago
Reviewers:
jennyz, Qiang(Joe) Xu
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of tabing inconsistencies between trays in status area (patchset #3 id:40001 of https://codereview.chromium.org/2087703002/ ) Reason for revert: I think this collided with https://codereview.chromium.org/2091933002/ and broke the build: c:\b\build\slave\win\build\src\ash\system\web_notification\web_notification_tray.cc(510): error C3861: 'status_area_widget': identifier not found https://build.chromium.org/p/chromium/buildstatus?builder=Win&number=44650 Original issue's description: > Detailed reproduce steps are in comment 2 in crbug.com/468969 > > There are several bugs in the status area tray focus advancing. > > (1) there is a invisible focus between system tray and web notification tray. This is because there is a focus traversal in web notification tray's child. Solution is to disable it. > When virtual keyboard is enabled, we should also disable its child view traversal. > > (2) TAB will be trapped in system tray. Web notification tray is async painted. The initialization sibling relation may not be ready. Add a setnextfocusibleview call will fix that. > > BUG=468969 > TEST=tested on device, both tabing and shift-tabing works well on status area. > > There is still a bug in crbug.com/468969 comment 7. It happens in login screen only. When logged in, it works fine. > > Committed: https://crrev.com/133c792af9dfe8c82561bee7015efcc0b5dba22d > Cr-Commit-Position: refs/heads/master@{#401765} TBR=jennyz@chromium.org,warx@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=468969 Committed: https://crrev.com/1c74487d2fedacf44e9267e552b6575fc5a6ce11 Cr-Commit-Position: refs/heads/master@{#401784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
falken
Created Revert of tabing inconsistencies between trays in status area
4 years, 6 months ago (2016-06-24 02:07:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090353005/1
4 years, 6 months ago (2016-06-24 02:07:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 02:08:03 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 02:09:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c74487d2fedacf44e9267e552b6575fc5a6ce11
Cr-Commit-Position: refs/heads/master@{#401784}

Powered by Google App Engine
This is Rietveld 408576698