Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 2090343006: swarmbucket: support for repository property (Closed)

Created:
4 years, 6 months ago by nodir
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

swarmbucket: support for repository property add native support for repository build property, see a long comment about it in code R=vadimsh@chromium.org, tandrii@chromium.org BUG=617472 Committed: https://chromium.googlesource.com/infra/infra/+/2abc127a23b679305433bd629942e0131b4c35ee

Patch Set 1 #

Patch Set 2 : swarmbucket: support for repository property #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -19 lines) Patch
M appengine/cr-buildbucket/swarming/swarming.py View 1 2 chunks +47 lines, -13 lines 0 comments Download
M appengine/cr-buildbucket/swarming/test/swarming_test.py View 3 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nodir
PTAL
4 years, 6 months ago (2016-06-23 23:47:16 UTC) #1
Vadim Sh.
lgtm
4 years, 6 months ago (2016-06-24 00:26:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090343006/20001
4 years, 6 months ago (2016-06-24 00:38:16 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/infra/infra/+/2abc127a23b679305433bd629942e0131b4c35ee
4 years, 6 months ago (2016-06-24 00:52:35 UTC) #6
tandrii(chromium)
4 years, 6 months ago (2016-06-24 13:02:03 UTC) #7
Message was sent while issue was closed.
LGTM  and thanks!

Powered by Google App Engine
This is Rietveld 408576698