swarmbucket: support for repository property

appengine/cr-buildbucket/swarming/test/swarming_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 import contextlib
 import datetime
 import json
 
 from components import auth
@@ skipping 93 matching lines @@
         bucket='bucket',
         parameters={'builder_name': 'builder'}
     )
     self.assertTrue(swarming.is_for_swarming_async(build).get_result())
 
     config_component.get_self_config_async.return_value = futuristic(
       (None, None))
     self.assertFalse(swarming.is_for_swarming_async(build).get_result())
 
   def test_build_parameters(self):
-    with self.assertRaises(errors.InvalidInputError):
-      swarming.validate_build_parameters('foo', {'properties': []})
-    with self.assertRaises(errors.InvalidInputError):
-      swarming.validate_build_parameters('foo', {
-        'properties': {'buildername': 'bar'},
-      })
+    bad = [
+      {'properties': []},
+      {'properties': {'buildername': 'bar'}},
+      {'changes': 0},
+      {'changes': [0]},
+      {'changes': [{'author': 0}]},
+      {'changes': [{'author': {}}]},
+      {'changes': [{'author': {'email': 0}}]},
+      {'changes': [{'author': {'email': ''}}]},
+      {'changes': [{'author': {'email': 'a@example.com'}, 'repo_url': 0}]},
+    ]
+    for p in bad:
+      with self.assertRaises(errors.InvalidInputError):
+        swarming.validate_build_parameters('foo', p)
 
   def test_validate_swarming_param(self):
     def validate_swarming_param(value):
       swarming.validate_build_parameters('builder', {'swarming': value})
 
     validate_swarming_param(None)
     validate_swarming_param({})
     validate_swarming_param({'recipe': {}})
     validate_swarming_param({'recipe': {'revision': 'deadbeef'}})
 
@@ skipping 34 matching lines @@
       parameters={
         'builder_name': 'builder',
         'swarming': {
           'recipe': {'revision': 'badcoffee'},
         },
         'properties': {
           'a': 'b',
         },
         'changes': [{
           'author': {'email': 'bob@example.com'},
+          'repo_url': 'https://chromium.googlesource.com/chromium/src',
         }]
       },
     )
 
     self.mock(net, 'json_request_async', mock.Mock(return_value=futuristic({
       'task_id': 'deadbeef',
       'request': {
         'properties': {
           'dimensions': [
             {'key': 'cores', 'value': '8'},
@@ skipping 46 matching lines @@
         'extra_args': [
           'cook',
           '-repository', 'https://example.com/repo',
           '-revision', 'badcoffee',
           '-recipe', 'recipe',
           '-properties', json.dumps({
             'a': 'b',
             'blamelist': ['bob@example.com'],
             'buildername': 'builder',
             'predefined-property': 'x',
+            'repository': 'https://chromium.googlesource.com/chromium/src',
           }, sort_keys=True)
         ],
         'dimensions': sorted([
           {'key': 'cores', 'value': '8'},
           {'key': 'os', 'value': 'Linux'},
           {'key': 'pool', 'value': 'Chrome'},
         ]),
       },
       'pubsub_topic': 'projects/testbed-test/topics/swarming',
       'pubsub_userdata': json.dumps({
@@ skipping 350 matching lines @@
     self.assertEqual(build.status, model.BuildStatus.COMPLETED)
     self.assertEqual(build.result, model.BuildResult.FAILURE)
     self.assertEqual(build.failure_reason, model.FailureReason.INFRA_FAILURE)
     self.assertIsNotNone(build.result_details)
     self.assertIsNone(build.lease_key)
     self.assertIsNotNone(build.complete_time)
 
 
 def b64json(data):
   return base64.b64encode(json.dumps(data))