src/isolate.cc - Issue 2090333002: Use instance type in Object::IsErrorObject().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 2090333002: Use instance type in Object::IsErrorObject(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@RefactorToString

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index c5e2640544d0f352d3eea38b8e004812d6414c7a..cff41b1c79e369f46d933b67883f32fbc308d61b 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -1454,7 +1454,7 @@ Handle<JSMessageObject> Isolate::CreateMessage(Handle<Object> exception,

MessageLocation* location) {

Handle<JSArray> stack_trace_object;

if (capture_stack_trace_for_uncaught_exceptions_) {

- if (Object::IsErrorObject(this, exception)) {

+ if (exception->IsJSError()) {

// We fetch the stack trace that corresponds to this error object.

// If the lookup fails, the exception is probably not a valid Error

// object. In that case, we fall through and capture the stack trace

« no previous file with comments | « src/api.cc ('k') | src/messages.cc » ('j') | no next file with comments »