chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h - Issue 2090133003: Moved methods that don't rely on internal state out of ChromeLauncherController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

Issue 2090133003: Moved methods that don't rely on internal state out of ChromeLauncherController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit changes Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller.h ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

index 5fd2d89595266ea582f5bbd152cca6cebe3d56e3..0b860cb429e6667e808bb3f07ba7c593ac557943 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

@@ -114,8 +114,6 @@ class ChromeLauncherControllerImpl

ash::ShelfID GetShelfIDForWebContents(

content::WebContents* contents) override;

void SetRefocusURLPatternForTest(ash::ShelfID id, const GURL& url) override;

- const extensions::Extension* GetExtensionForAppID(

- const std::string& app_id) const override;

ash::ShelfItemDelegate::PerformedAction ActivateWindowOrMinimizeIfActive(

ui::BaseWindow* window,

bool allow_minimize) override;

@@ -138,13 +136,10 @@ class ChromeLauncherControllerImpl

void MayUpdateBrowserShortcutItem() override;

LauncherItemController* GetLauncherItemController(

const ash::ShelfID id) override;

- bool IsBrowserFromActiveUser(Browser* browser) override;

bool ShelfBoundsChangesProbablyWithUser(

ash::Shelf* shelf,

const std::string& user_id) const override;

void OnUserProfileReadyToSwitch(Profile* profile) override;

- AppListControllerDelegate::Pinnable GetPinnable(

- const std::string& app_id) override;

ArcAppDeferredLauncherController* GetArcDeferredLauncher() override;

// Access to the BrowserStatusMonitor for tests.