Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

Issue 2090133003: Moved methods that don't rely on internal state out of ChromeLauncherController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit changes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
index d476b2ee923d8ca73cca5bbfb9091891f4b0adc7..ec0b8691fab7dc1434392c9d9263c697825bc077 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
@@ -172,10 +172,6 @@ class ChromeLauncherController {
virtual void SetRefocusURLPatternForTest(ash::ShelfID id,
const GURL& url) = 0;
- // Returns the extension identified by |app_id|.
- virtual const extensions::Extension* GetExtensionForAppID(
- const std::string& app_id) const = 0;
-
// Activates a |window|. If |allow_minimize| is true and the system allows
// it, the the window will get minimized instead.
// Returns the action performed. Should be one of kNoAction,
@@ -236,9 +232,6 @@ class ChromeLauncherController {
virtual LauncherItemController* GetLauncherItemController(
const ash::ShelfID id) = 0;
- // Returns true if |browser| is owned by the active user.
- virtual bool IsBrowserFromActiveUser(Browser* browser) = 0;
-
// Check if the shelf visibility (location, visibility) will change with a new
// user profile or not. However, since the full visibility calculation of the
// shelf cannot be performed here, this is only a probability used for
@@ -250,10 +243,6 @@ class ChromeLauncherController {
// Called when the user profile is fully loaded and ready to switch to.
virtual void OnUserProfileReadyToSwitch(Profile* profile) = 0;
- // TODO(khmel): Find better home for Pinnable enum.
- virtual AppListControllerDelegate::Pinnable GetPinnable(
- const std::string& app_id) = 0;
-
// Controller to launch Arc apps in deferred mode.
virtual ArcAppDeferredLauncherController* GetArcDeferredLauncher() = 0;

Powered by Google App Engine
This is Rietveld 408576698