Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Issue 2090033003: Remove special cases for WPT path rewriting (Closed)

Created:
4 years, 6 months ago by Rick Byers
Modified:
4 years, 5 months ago
Reviewers:
tkent, Avi (use Gerrit)
CC:
qyearsley, chromium-reviews, darin-cc_chromium.org, dcampb, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, raikiri
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove special cases for WPT path rewriting Now that we rewrite absolute paths only when running WPT tests, there's no longer any need to try to detect the names of the paths to rewrite. Instead just rewrite all absolute paths (that aren't already inside LayoutTests). BUG=498120 Committed: https://crrev.com/74c476b03793ce0ba9bfda73d96a8142792f07b4 Cr-Commit-Position: refs/heads/master@{#402858}

Patch Set 1 #

Patch Set 2 : Update expectations #

Patch Set 3 : Undo W3CTestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -21 lines) Patch
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 1 chunk +6 lines, -21 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (7 generated)
Rick Byers
tkent@ PTAL
4 years, 6 months ago (2016-06-23 19:44:39 UTC) #3
Rick Byers
On 2016/06/23 19:44:39, Rick Byers wrote: > tkent@ PTAL Note that I'll actually get these ...
4 years, 6 months ago (2016-06-23 20:35:36 UTC) #4
Rick Byers
On 2016/06/23 20:35:36, Rick Byers wrote: > On 2016/06/23 19:44:39, Rick Byers wrote: > > ...
4 years, 6 months ago (2016-06-23 20:37:29 UTC) #5
tkent
Now the function is called only if we are running WPT tests. So this change ...
4 years, 6 months ago (2016-06-23 23:01:53 UTC) #6
Rick Byers
On 2016/06/23 23:01:53, tkent wrote: > Now the function is called only if we are ...
4 years, 5 months ago (2016-06-29 15:51:14 UTC) #7
Rick Byers
On 2016/06/29 15:51:14, Rick Byers wrote: > On 2016/06/23 23:01:53, tkent wrote: > > Now ...
4 years, 5 months ago (2016-06-29 15:51:39 UTC) #9
Avi (use Gerrit)
lgtm
4 years, 5 months ago (2016-06-29 16:15:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2090033003/40001
4 years, 5 months ago (2016-06-29 16:20:19 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 17:46:00 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 17:46:37 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 17:47:50 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/74c476b03793ce0ba9bfda73d96a8142792f07b4
Cr-Commit-Position: refs/heads/master@{#402858}

Powered by Google App Engine
This is Rietveld 408576698