Fix memory-issue String::fromCharCodes, where a GC could invalidate an address.

runtime/vm/object.h

Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 6c71efdcb071cdfe28f7907b71412807a0357cd3..b9b5ca40e64cfd3ab9ef1f06e7bf16bb14781fa9 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -5306,6 +5306,16 @@ class OneByteString : public AllStatic {
                                intptr_t other_len,
                                Heap::Space space);
 
+  static RawOneByteString* New(const TypedData& other_typed_data,
+                               intptr_t other_start_index,
+                               intptr_t other_len,
+                               Heap::Space space);

[Ivan Posva, 2014/03/24 18:30:43]

"Heap::Space space = Heap::kNew" and then you can remove them at the call sites.

I do know that some of the ones here do not have them, we should clean that up
as well. Different CL though.

[Anders Johnsen, 2014/03/24 18:48:46]

Done.

+
+  static RawOneByteString* New(const ExternalTypedData& other_typed_data,
+                               intptr_t other_start_index,
+                               intptr_t other_len,
+                               Heap::Space space);

[Ivan Posva, 2014/03/24 18:30:43]

ditto

[Anders Johnsen, 2014/03/24 18:48:46]

Done.

+
   static RawOneByteString* Concat(const String& str1,
                                   const String& str2,
                                   Heap::Space space);