Fix memory-issue String::fromCharCodes, where a GC could invalidate an address.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 5288 matching lines @@
                                intptr_t len,
                                Heap::Space space);
   static RawOneByteString* New(const String& str,
                                Heap::Space space);
   // 'other' must be OneByteString.
   static RawOneByteString* New(const String& other_one_byte_string,
                                intptr_t other_start_index,
                                intptr_t other_len,
                                Heap::Space space);
 
+  static RawOneByteString* New(const TypedData& other_typed_data,
+                               intptr_t other_start_index,
+                               intptr_t other_len,
+                               Heap::Space space);

[Ivan Posva, 2014/03/24 18:30:43]

"Heap::Space space = Heap::kNew" and then you can remove them at the call sites.

I do know that some of the ones here do not have them, we should clean that up
as well. Different CL though.

[Anders Johnsen, 2014/03/24 18:48:46]

Done.

+
+  static RawOneByteString* New(const ExternalTypedData& other_typed_data,
+                               intptr_t other_start_index,
+                               intptr_t other_len,
+                               Heap::Space space);

[Ivan Posva, 2014/03/24 18:30:43]

ditto

[Anders Johnsen, 2014/03/24 18:48:46]

Done.

+
   static RawOneByteString* Concat(const String& str1,
                                   const String& str2,
                                   Heap::Space space);
   static RawOneByteString* ConcatAll(const Array& strings,
                                      intptr_t start,
                                      intptr_t end,
                                      intptr_t len,
                                      Heap::Space space);
 
   static RawOneByteString* Transform(int32_t (*mapping)(int32_t ch),
@@ skipping 1427 matching lines @@
 
 
 RawObject* MegamorphicCache::GetTargetFunction(const Array& array,
                                                intptr_t index) {
   return array.At((index * kEntryLength) + kTargetFunctionIndex);
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_