Context Menu Refactor

components/web_contents_delegate_android/DEPS

Index: components/web_contents_delegate_android/DEPS
diff --git a/components/web_contents_delegate_android/DEPS b/components/web_contents_delegate_android/DEPS
index 0cbb2748a7ca8ed3da314cee45d5513eb1aca382..f4c3160d8488235379230fe36f84bca9452d3e2b 100644
--- a/components/web_contents_delegate_android/DEPS
+++ b/components/web_contents_delegate_android/DEPS
@@ -1,4 +1,5 @@
 include_rules = [
+  "+content/browser/renderer_host/render_widget_host_view_android.h",

[no sievers, 2016/06/23 23:16:41]

Can we avoid the non-public dependency here somehow?

I'm wondering:

What if SelectActionMode moved to ui/android (also see ui/touch_selection)?

Instead of RWHV then ViewAndroid could own the SelectActionMode instance and you
could get to it here through RWHV::GetNativeView() (which is public).

[amaralp, 2016/06/24 00:45:49]

I also didn't like the non-public dependency, but I'm not sure I understand your
suggestion. Isn't ViewAndroid an abstract class? What subclass would
implement it once ContentViewCore is gone?

[no sievers, 2016/06/24 22:17:25]

Feel free to add view_android.cc. I was going to do that anyways with
crbug.com/622847.

Otherwise you could also override the implementation through CVC in the
meantime.
You could even delegate the implementation from ViewAndroid to its delegate
(ViewAndroidDelagate?) which should be then implemented by RWHVAndroid. I was
going to add that delegate interface also for aforementioned bug.

   "+content/public/browser",
   "+content/public/common",
   "+jni",