components/web_contents_delegate_android/DEPS - Issue 2089933002: Context Menu Refactor

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/web_contents_delegate_android/DEPS

Issue 2089933002: Context Menu Refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unnecessary code Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc ('K') | « chrome/browser/ui/views/profiles/profile_chooser_view.cc ('k') | components/web_contents_delegate_android/web_contents_delegate_android.h » ('j') | content/browser/renderer_host/render_widget_host_view_android.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+content/browser/renderer_host/render_widget_host_view_android.h",
	no sievers 2016/06/23 23:16:41 Can we avoid the non-public dependency here someho Can we avoid the non-public dependency here somehow? I'm wondering: What if SelectActionMode moved to ui/android (also see ui/touch_selection)? Instead of RWHV then ViewAndroid could own the SelectActionMode instance and you could get to it here through RWHV::GetNativeView() (which is public). amaralp 2016/06/24 00:45:49 I also didn't like the non-public dependency, but Show quoted text On 2016/06/23 at 23:16:41, sievers wrote: > Can we avoid the non-public dependency here somehow? > > I'm wondering: > > What if SelectActionMode moved to ui/android (also see ui/touch_selection)? > > Instead of RWHV then ViewAndroid could own the SelectActionMode instance and you could get to it here through RWHV::GetNativeView() (which is public). I also didn't like the non-public dependency, but I'm not sure I understand your suggestion. Isn't ViewAndroid an abstract class? What subclass would implement it once ContentViewCore is gone? no sievers 2016/06/24 22:17:25 Feel free to add view_android.cc. I was going to d Show quoted text On 2016/06/24 00:45:49, amaralp wrote: > On 2016/06/23 at 23:16:41, sievers wrote: > > Can we avoid the non-public dependency here somehow? > > > > I'm wondering: > > > > What if SelectActionMode moved to ui/android (also see ui/touch_selection)? > > > > Instead of RWHV then ViewAndroid could own the SelectActionMode instance and > you could get to it here through RWHV::GetNativeView() (which is public). > > I also didn't like the non-public dependency, but I'm not sure I understand your > suggestion. Isn't ViewAndroid an abstract class? What subclass would > implement it once ContentViewCore is gone? Feel free to add view_android.cc. I was going to do that anyways with crbug.com/622847. Otherwise you could also override the implementation through CVC in the meantime. You could even delegate the implementation from ViewAndroid to its delegate (ViewAndroidDelagate?) which should be then implemented by RWHVAndroid. I was going to add that delegate interface also for aforementioned bug.
2 "+content/public/browser",	3 "+content/public/browser",

3 "+content/public/common",	4 "+content/public/common",

4 "+jni",	5 "+jni",

5 "+ui/android/window_android.h",	6 "+ui/android/window_android.h",

6 "+ui/base",	7 "+ui/base",

7 "+ui/gfx",	8 "+ui/gfx",

8 ]	9 ]

OLD	NEW