content/browser/renderer_host/compositor_impl_android.cc - Issue 2089753003: cc: Use the correct internal format for glCopyTexImage2D calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/compositor_impl_android.cc

Issue 2089753003: cc: Use the correct internal format for glCopyTexImage2D calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: copytextureformat: comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/software_browser_compositor_output_surface.cc ('k') | content/common/gpu/client/context_provider_command_buffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/compositor_impl_android.cc

diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc

index a2065343d99d81f758a04410dbfacf859c399e80..fa3b000368fcfb135329d92f49f40dcae4b133e9 100644

--- a/content/browser/renderer_host/compositor_impl_android.cc

+++ b/content/browser/renderer_host/compositor_impl_android.cc

@@ -202,6 +202,11 @@ class OutputSurfaceWithoutParent : public cc::OutputSurface {

return overlay_candidate_validator_.get();

}

+ uint32_t GetFramebufferCopyTextureFormat() override {

+ auto* gl = static_cast<ContextProviderCommandBuffer*>(context_provider());

+ return gl->GetCopyTextureInternalFormat();

+ }

private:

gpu::CommandBufferProxyImpl* GetCommandBufferProxy() {

ContextProviderCommandBuffer* provider_command_buffer =