content/browser/compositor/software_browser_compositor_output_surface.cc - Issue 2089753003: cc: Use the correct internal format for glCopyTexImage2D calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/software_browser_compositor_output_surface.cc

Issue 2089753003: cc: Use the correct internal format for glCopyTexImage2D calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: copytextureformat: comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/software_browser_compositor_output_surface.h ('k') | content/browser/renderer_host/compositor_impl_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/software_browser_compositor_output_surface.cc

diff --git a/content/browser/compositor/software_browser_compositor_output_surface.cc b/content/browser/compositor/software_browser_compositor_output_surface.cc

index 14e78eb5f15240a1b82c117857e53c8b35794451..ed1afe38bb3ec8d0e134645231b99989b574c382 100644

--- a/content/browser/compositor/software_browser_compositor_output_surface.cc

+++ b/content/browser/compositor/software_browser_compositor_output_surface.cc

@@ -57,6 +57,18 @@ void SoftwareBrowserCompositorOutputSurface::SwapBuffers(

client_->DidSwapBuffers();

}

+void SoftwareBrowserCompositorOutputSurface::BindFramebuffer() {

+ // Not used for software surfaces.

+ NOTREACHED();

+GLenum

+SoftwareBrowserCompositorOutputSurface::GetFramebufferCopyTextureFormat() {

+ // Not used for software surfaces.

+ NOTREACHED();

+ return 0;

void SoftwareBrowserCompositorOutputSurface::OnGpuSwapBuffersCompleted(

const std::vector<ui::LatencyInfo>& latency_info,

gfx::SwapResult result,