Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 6 months ago by tandrii(chromium) Modified:
4 years, 5 months ago Reviewers:
agable CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionGerrit git cl land: add warning if Commit-Queue label exists.
BUG=612727
R=agable@chromium.org
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d60367ba30630ce4091baed2a6dae4bd55e15b5e
Patch Set 1 #
Total comments: 5
Patch Set 2 : review #Messages
Total messages: 13 (5 generated)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089683002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM with optional nits on phrasing. https://codereview.chromium.org/2089683002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2089683002/diff/1/git_cl.py#newcode2247 git_cl.py:2247: ask_for_data('\nIt seems this repository has a Commit Queue, ' "This repository has..." No need to be wishy-washy about it :P https://codereview.chromium.org/2089683002/diff/1/git_cl.py#newcode2248 git_cl.py:2248: 'which can test and land changes for you. \n' "...land changes for you. Are you sure you wish to bypass it?\n'
https://codereview.chromium.org/2089683002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2089683002/diff/1/git_cl.py#newcode2247 git_cl.py:2247: ask_for_data('\nIt seems this repository has a Commit Queue, ' On 2016/06/21 16:43:54, agable wrote: > "This repository has..." > > No need to be wishy-washy about it :P ChromeOS folks defined Commit-Queue label in All Projects in Gerrit. So, until these permissions are cleaned up, this is indeed "seems". https://codereview.chromium.org/2089683002/diff/1/git_cl.py#newcode2248 git_cl.py:2248: 'which can test and land changes for you. \n' On 2016/06/21 16:43:54, agable wrote: > "...land changes for you. Are you sure you wish to bypass it?\n' Done.
The CQ bit was checked by tandrii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from agable@chromium.org Link to the patchset: https://codereview.chromium.org/2089683002/#ps20001 (title: "review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089683002/20001
Message was sent while issue was closed.
Description was changed from ========== Gerrit git cl land: add warning if Commit-Queue label exists. BUG=612727 R=agable@chromium.org ========== to ========== Gerrit git cl land: add warning if Commit-Queue label exists. BUG=612727 R=agable@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d60367ba30630c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/d60367ba30630c...
Message was sent while issue was closed.
https://codereview.chromium.org/2089683002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2089683002/diff/1/git_cl.py#newcode2247 git_cl.py:2247: ask_for_data('\nIt seems this repository has a Commit Queue, ' On 2016/06/21 17:33:29, tandrii(chromium) wrote: > On 2016/06/21 16:43:54, agable wrote: > > "This repository has..." > > > > No need to be wishy-washy about it :P > > ChromeOS folks defined Commit-Queue label in All Projects in Gerrit. So, until > these permissions are cleaned up, this is indeed "seems". and you did the cleanup, and this it still is "seems" http://crbug.com/630707 |
