Gerrit git cl land: add warning if Commit-Queue label exists.

Gerrit git cl land: add warning if Commit-Queue label exists.

BUG=612727
R=agable@chromium.org

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d60367ba30630ce4091baed2a6dae4bd55e15b5e

[tandrii(chromium), 2016-06-21 16:13:01]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 16:13:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2089683002/1

[commit-bot: I haz the power, 2016-06-21 16:16:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 16:16:14]

Dry run: This issue passed the CQ dry run.

[agable, 2016-06-21 16:43:55]

LGTM with optional nits on phrasing.

https://codereview.chromium.org/2089683002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2089683002/diff/1/git_cl.py#newcode2247
git_cl.py:2247: ask_for_data('\nIt seems this repository has a Commit Queue, '
"This repository has..."

No need to be wishy-washy about it :P

https://codereview.chromium.org/2089683002/diff/1/git_cl.py#newcode2248
git_cl.py:2248: 'which can test and land changes for you. \n'
"...land changes for you. Are you sure you wish to bypass it?\n'

[tandrii(chromium), 2016-06-21 17:33:30]

https://codereview.chromium.org/2089683002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2089683002/diff/1/git_cl.py#newcode2247
git_cl.py:2247: ask_for_data('\nIt seems this repository has a Commit Queue, '
On 2016/06/21 16:43:54, agable wrote:
> "This repository has..."
> 
> No need to be wishy-washy about it :P

ChromeOS folks defined Commit-Queue label in All Projects in Gerrit. So, until
these permissions are cleaned up, this is indeed "seems".

https://codereview.chromium.org/2089683002/diff/1/git_cl.py#newcode2248
git_cl.py:2248: 'which can test and land changes for you. \n'
On 2016/06/21 16:43:54, agable wrote:
> "...land changes for you. Are you sure you wish to bypass it?\n'

Done.

[tandrii(chromium), 2016-06-22 12:21:52]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-06-22 12:21:53]

The patchset sent to the CQ was uploaded after l-g-t-m from agable@chromium.org
Link to the patchset: https://codereview.chromium.org/2089683002/#ps20001
(title: "review")

[commit-bot: I haz the power, 2016-06-22 12:21:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2089683002/20001

[commit-bot: I haz the power, 2016-06-22 12:25:14]

Description was changed from

==========
Gerrit git cl land: add warning if Commit-Queue label exists.

BUG=612727
R=agable@chromium.org
==========

to

==========
Gerrit git cl land: add warning if Commit-Queue label exists.

BUG=612727
R=agable@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/d60367ba30630c...
==========

[commit-bot: I haz the power, 2016-06-22 12:25:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/d60367ba30630c...

[tandrii(chromium), 2016-07-25 09:39:32]

https://codereview.chromium.org/2089683002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2089683002/diff/1/git_cl.py#newcode2247
git_cl.py:2247: ask_for_data('\nIt seems this repository has a Commit Queue, '
On 2016/06/21 17:33:29, tandrii(chromium) wrote:
> On 2016/06/21 16:43:54, agable wrote:
> > "This repository has..."
> > 
> > No need to be wishy-washy about it :P
> 
> ChromeOS folks defined Commit-Queue label in All Projects in Gerrit. So, until
> these permissions are cleaned up, this is indeed "seems".

and you did the cleanup, and this it still is "seems" http://crbug.com/630707