Gerrit git cl land: add warning if Commit-Queue label exists.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld and Gerrit."""
 
 from __future__ import print_function
@@ skipping 2223 matching lines @@
   def _GetChangeDetail(self, options=None, issue=None):
     options = options or []
     issue = issue or self.GetIssue()
     assert issue, 'issue required to query Gerrit'
     return gerrit_util.GetChangeDetail(self._GetGerritHost(), str(issue),
                                        options)
 
   def CMDLand(self, force, bypass_hooks, verbose):
     if git_common.is_dirty_git_tree('land'):
       return 1
+    detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
+    if u'Commit-Queue' in detail.get('labels', {}):
+      if not force:
+        ask_for_data('\nIt seems this repository has a Commit Queue, '

[agable, 2016/06/21 16:43:54]

"This repository has..."

No need to be wishy-washy about it :P

[tandrii(chromium), 2016/06/21 17:33:29]

ChromeOS folks defined Commit-Queue label in All Projects in Gerrit. So, until
these permissions are cleaned up, this is indeed "seems".

[tandrii(chromium), 2016/07/25 09:39:32]

and you did the cleanup, and this it still is "seems" http://crbug.com/630707

+                     'which can test and land changes for you. \n'

[agable, 2016/06/21 16:43:54]

"...land changes for you. Are you sure you wish to bypass it?\n'

[tandrii(chromium), 2016/06/21 17:33:29]

Done.

+                     'Press Enter to continue, Ctrl+C to abort.')
+
     differs = True
     last_upload = RunGit(['config',
                           'branch.%s.gerritsquashhash' % self.GetBranch()],
                          error_ok=True).strip()
     # Note: git diff outputs nothing if there is no diff.
     if not last_upload or RunGit(['diff', last_upload]).strip():
       print('WARNING: some changes from local branch haven\'t been uploaded')
     else:
-      detail = self._GetChangeDetail(['CURRENT_REVISION'])
       if detail['current_revision'] == last_upload:
         differs = False
       else:
         print('WARNING: local branch contents differ from latest uploaded '
               'patchset')
     if differs:
       if not force:
         ask_for_data(
             'Do you want to submit latest Gerrit patchset and bypass hooks?')
       print('WARNING: bypassing hooks and submitting latest uploaded patchset')
@@ skipping 2779 matching lines @@
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   setup_color.init()
   try:
     sys.exit(main(sys.argv[1:]))
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
     sys.exit(1)