Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2089673002:
Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. (Closed)
|
Created:
4 years, 6 months ago by rmcilroy Modified:
4 years, 6 months ago Reviewers:
Benedikt Meurer CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionReland: [Crankshaft] Always check for stubs marked to not require an eager frame.
Previously only stubs built in the snapshot were checked for having an
eager frame. This caused a regression to creap in on ia32 for
RegExpConstructResultStub. Change test to always check.
CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
Committed: https://crrev.com/1b4e0130faee8115fae274f1d2c46cfa8ae5f415
Cr-Commit-Position: refs/heads/master@{#37181}
Patch Set 1 #Patch Set 2 #Patch Set 3 : Reland #
Dependent Patchsets: Messages
Total messages: 34 (17 generated)
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089673002/1
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089673002/20001
rmcilroy@chromium.org changed reviewers: + bmeurer@chromium.org
Benedikit, this addresses the failures on https://codereview.chromium.org/2051573002/. I chatted to Danno who originally added the check and he didn't think there was any good reason it was only checking for stubs built in the snapshot. PTAL, thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bmeurer@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089673002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Crankshaft] Always check for stubs marked to not require an eager frame. Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. ========== to ========== [Crankshaft] Always check for stubs marked to not require an eager frame. Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. Committed: https://crrev.com/f6facbb2106ffc2918dd249166233a7fa95dc449 Cr-Commit-Position: refs/heads/master@{#37162} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f6facbb2106ffc2918dd249166233a7fa95dc449 Cr-Commit-Position: refs/heads/master@{#37162}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2087963004/ by bmeurer@chromium.org. The reason for reverting is: Breaks with nosnap: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2....
Message was sent while issue was closed.
Description was changed from ========== [Crankshaft] Always check for stubs marked to not require an eager frame. Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. Committed: https://crrev.com/f6facbb2106ffc2918dd249166233a7fa95dc449 Cr-Commit-Position: refs/heads/master@{#37162} ========== to ========== Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. Committed: https://crrev.com/f6facbb2106ffc2918dd249166233a7fa95dc449 Cr-Commit-Position: refs/heads/master@{#37162} ==========
Description was changed from ========== Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. Committed: https://crrev.com/f6facbb2106ffc2918dd249166233a7fa95dc449 Cr-Commit-Position: refs/heads/master@{#37162} ========== to ========== Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. CQ_EXTRA_TRYBOTS=v8_linux_nosnap_dbg ==========
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089673002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Transient error: Invalid delimiter in "v8_linux_nosnap_dbg": Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
Relanding with a fix for the nosnap build.
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089673002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Transient error: Invalid delimiter in "v8_linux_nosnap_dbg": Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
Description was changed from ========== Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. CQ_EXTRA_TRYBOTS=v8_linux_nosnap_dbg ========== to ========== Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg ==========
The CQ bit was checked by rmcilroy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org Link to the patchset: https://codereview.chromium.org/2089673002/#ps40001 (title: "Reland")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089673002/40001
Message was sent while issue was closed.
Description was changed from ========== Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg ========== to ========== Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg ========== to ========== Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg Committed: https://crrev.com/1b4e0130faee8115fae274f1d2c46cfa8ae5f415 Cr-Commit-Position: refs/heads/master@{#37181} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1b4e0130faee8115fae274f1d2c46cfa8ae5f415 Cr-Commit-Position: refs/heads/master@{#37181} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
