Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2051573002: [Interpreter] Add intrinsics called as stubs. (Closed)

Created:
4 years, 6 months ago by rmcilroy
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add intrinsics called as stubs. Adds support for intrinsics which can be called as stubs. Namely: - HasProperty - MathPow - NewObject - NumberToString - RegExpConstructResult - RegExpExec - Substring - ToString - ToName - ToLength - ToNumber - ToObject Also adds interface descriptors for stub calls which have arguments passed on the stack. BUG=v8:4280 LOG=N Committed: https://crrev.com/485e77519f45fa60013ca83da8cff3a75a14037a Cr-Commit-Position: refs/heads/master@{#37185}

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Fix leak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -24 lines) Patch
M src/code-factory.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 4 chunks +15 lines, -5 lines 0 comments Download
M src/compiler/code-assembler.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 1 6 chunks +79 lines, -9 lines 0 comments Download
M src/interface-descriptors.cc View 1 2 chunks +42 lines, -1 line 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 1 2 3 4 5 3 chunks +29 lines, -8 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 1 2 3 4 5 3 chunks +79 lines, -1 line 0 comments Download
M test/cctest/interpreter/test-interpreter-intrinsics.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051573002/1
4 years, 6 months ago (2016-06-08 20:02:59 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/2871)
4 years, 6 months ago (2016-06-08 20:08:09 UTC) #4
rmcilroy
Benedkit, PTAL, thanks.
4 years, 6 months ago (2016-06-20 16:22:04 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051573002/40001
4 years, 6 months ago (2016-06-20 16:22:35 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/7540)
4 years, 6 months ago (2016-06-20 16:27:05 UTC) #10
Benedikt Meurer
LGTM modulo (Crankshaft) serializer issues.
4 years, 6 months ago (2016-06-21 07:25:33 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051573002/60001
4 years, 6 months ago (2016-06-21 15:33:09 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/builds/3578) v8_presubmit on ...
4 years, 6 months ago (2016-06-21 15:37:21 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051573002/80001
4 years, 6 months ago (2016-06-22 11:32:55 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/3636)
4 years, 6 months ago (2016-06-22 11:40:29 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051573002/100001
4 years, 6 months ago (2016-06-22 11:56:26 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-22 12:22:40 UTC) #23
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 12:22:57 UTC) #25
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/485e77519f45fa60013ca83da8cff3a75a14037a
Cr-Commit-Position: refs/heads/master@{#37185}

Powered by Google App Engine
This is Rietveld 408576698