Issue 2089653002: [Mac][Material Design] Fix bookmark chevron button focus ring location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2089653002: [Mac][Material Design] Fix bookmark chevron button focus ring location. (Closed)

Created:
4 years, 6 months ago by shrike

Modified:
4 years, 6 months ago

Reviewers:
tapted

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

[Mac][Material Design] Fix bookmark chevron button focus ring location. This cl adjusts the bookmark bar's chevron button's focus ring, which is 2pt too low. R=tapted@chromium.org BUG=617511 Review-Url: https://codereview.chromium.org/2074503002 Cr-Commit-Position: refs/heads/master@{#400309} (cherry picked from commit ce0f71bffa40beb738e2579efd91d3a0260dd010) Committed: https://chromium.googlesource.com/chromium/src/+/9c8408ac25aa7b3381f35228bd267dff6d4528e0

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -6 lines)			Patch
	M	chrome/app/nibs/BookmarkBar.xib	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm	View		3 chunks	+27 lines, -5 lines	0 comments	Download

Total messages: 2 (1 generated)

shrike

4 years, 6 months ago (2016-06-21 15:02:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9c8408ac25aa7b3381f35228bd267dff6d4528e0.