Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 2074503002: [Mac][Material Design] Fix bookmark chevron button focus ring location. (Closed)

Created:
4 years, 6 months ago by shrike
Modified:
4 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Fix bookmark chevron button focus ring location. This cl adjusts the bookmark bar's chevron button's focus ring, which is 2pt too low. R=tapted@chromium.org BUG=617511 Committed: https://crrev.com/ce0f71bffa40beb738e2579efd91d3a0260dd010 Cr-Commit-Position: refs/heads/master@{#400309}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change how determine if cell is the offTheSideButtonCell. #

Patch Set 3 : Remove changes meant for another bug. #

Total comments: 2

Patch Set 4 : Remove unneeded includes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M chrome/app/nibs/BookmarkBar.xib View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 1 2 3 3 chunks +27 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
shrike
PTAL
4 years, 6 months ago (2016-06-15 21:58:16 UTC) #1
tapted
I think there's a nice way to avoid the rtti. And.. it's probably fine, but ...
4 years, 6 months ago (2016-06-16 05:53:19 UTC) #2
shrike
PTAL https://codereview.chromium.org/2074503002/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm (right): https://codereview.chromium.org/2074503002/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm#newcode380 chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm:380: bookmarkBarViewControllerFromControlView:(NSView*)controlView { On 2016/06/16 05:53:19, tapted wrote: > ...
4 years, 6 months ago (2016-06-16 15:19:09 UTC) #3
tapted
lgtm % nit https://codereview.chromium.org/2074503002/diff/40001/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm (right): https://codereview.chromium.org/2074503002/diff/40001/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm#newcode11 chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm:11: #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h" nit: remove these 2 ...
4 years, 6 months ago (2016-06-16 21:04:27 UTC) #4
shrike
https://codereview.chromium.org/2074503002/diff/40001/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm (right): https://codereview.chromium.org/2074503002/diff/40001/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm#newcode11 chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm:11: #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h" On 2016/06/16 21:04:26, tapted wrote: > nit: ...
4 years, 6 months ago (2016-06-16 22:52:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074503002/60001
4 years, 6 months ago (2016-06-16 22:52:38 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-17 00:15:01 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 00:16:18 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ce0f71bffa40beb738e2579efd91d3a0260dd010
Cr-Commit-Position: refs/heads/master@{#400309}

Powered by Google App Engine
This is Rietveld 408576698