Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1868)

Issue 2089503002: Merge M52: "Freeze media time and audio rendering when the system suspends." (Closed)

Created:
4 years, 6 months ago by DaleCurtis
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Merge M52: "Freeze media time and audio rendering when the system suspends." Allows us to avoid unexpected differences between what the audio renderer and video renderer think the current time is. Causes the wall clock time calculations to return false for "is time moving." With this information the video renderer (and other callers) can accurately act upon frozen moments and not expire frames due to a difference of opinion on what the current time is (audio only updates its base every Render() call). BUG=620478 TEST=new unittests Review-Url: https://codereview.chromium.org/2072843002 Cr-Commit-Position: refs/heads/master@{#400454} (cherry picked from commit e3fb958aa538c5b146afea7f9df498a579d3e5a4) Committed: https://chromium.googlesource.com/chromium/src/+/190fbd2f4ce6ff7617a4b60b22723dee6b5ec4ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
M media/renderers/audio_renderer_impl.h View 4 chunks +10 lines, -0 lines 0 comments Download
M media/renderers/audio_renderer_impl.cc View 5 chunks +36 lines, -2 lines 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 6 months ago (2016-06-20 23:08:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
190fbd2f4ce6ff7617a4b60b22723dee6b5ec4ce.

Powered by Google App Engine
This is Rietveld 408576698