Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: media/renderers/audio_renderer_impl_unittest.cc

Issue 2089503002: Merge M52: "Freeze media time and audio rendering when the system suspends." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/renderers/audio_renderer_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/audio_renderer_impl_unittest.cc
diff --git a/media/renderers/audio_renderer_impl_unittest.cc b/media/renderers/audio_renderer_impl_unittest.cc
index ce199235950578ce942d218e500d7fccc580b3f4..a1b475b4e748eb83c44fabe6e8d70099f23af7a8 100644
--- a/media/renderers/audio_renderer_impl_unittest.cc
+++ b/media/renderers/audio_renderer_impl_unittest.cc
@@ -747,6 +747,33 @@ TEST_F(AudioRendererImplTest, RenderingDelayedForEarlyStartTime) {
ASSERT_NE(0.0f, bus->channel(0)[i]);
}
+TEST_F(AudioRendererImplTest, RenderingDelayedForSuspend) {
+ Initialize();
+ Preroll(base::TimeDelta(), base::TimeDelta(), PIPELINE_OK);
+ StartTicking();
+
+ // Verify the first buffer is real data.
+ int frames_read = 0;
+ std::unique_ptr<AudioBus> bus = AudioBus::Create(hardware_params_);
+ EXPECT_TRUE(sink_->Render(bus.get(), 0, &frames_read));
+ EXPECT_NE(0, frames_read);
+ for (int i = 0; i < bus->frames(); ++i)
+ ASSERT_NE(0.0f, bus->channel(0)[i]);
+
+ // Verify after suspend we get silence.
+ renderer_->OnSuspend();
+ EXPECT_TRUE(sink_->Render(bus.get(), 0, &frames_read));
+ EXPECT_EQ(0, frames_read);
+
+ // Verify after resume we get audio.
+ bus->Zero();
+ renderer_->OnResume();
+ EXPECT_TRUE(sink_->Render(bus.get(), 0, &frames_read));
+ EXPECT_NE(0, frames_read);
+ for (int i = 0; i < bus->frames(); ++i)
+ ASSERT_NE(0.0f, bus->channel(0)[i]);
+}
+
TEST_F(AudioRendererImplTest, RenderingDelayDoesNotOverflow) {
Initialize();
@@ -858,6 +885,16 @@ TEST_F(AudioRendererImplTest, TimeSourceBehavior) {
ConvertMediaTime(base::TimeDelta(), &is_time_moving));
EXPECT_TRUE(is_time_moving);
+ // A system suspend should freeze the time state and resume restart it.
+ renderer_->OnSuspend();
+ EXPECT_EQ(tick_clock_->NowTicks(),
+ ConvertMediaTime(base::TimeDelta(), &is_time_moving));
+ EXPECT_FALSE(is_time_moving);
+ renderer_->OnResume();
+ EXPECT_EQ(tick_clock_->NowTicks(),
+ ConvertMediaTime(base::TimeDelta(), &is_time_moving));
+ EXPECT_TRUE(is_time_moving);
+
// Consume some more audio data.
frames_to_consume = frames_buffered();
tick_clock_->Advance(
« no previous file with comments | « media/renderers/audio_renderer_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698