Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2089413002: [Offline Pages] Create a event/activity logger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address initial comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.h
diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h
index cab867f2ef0546fd742ee85cb78e9d9f7507d3d5..b5e35c571ad67e9a4efc56c9e9741b13025e4f66 100644
--- a/components/offline_pages/background/request_coordinator.h
+++ b/components/offline_pages/background/request_coordinator.h
@@ -13,6 +13,7 @@
#include "components/keyed_service/core/keyed_service.h"
#include "components/offline_pages/background/device_conditions.h"
#include "components/offline_pages/background/offliner.h"
+#include "components/offline_pages/background/request_coordinator_event_logger.h"
#include "components/offline_pages/background/request_queue.h"
#include "components/offline_pages/background/scheduler.h"
#include "url/gurl.h"
@@ -87,6 +88,10 @@ class RequestCoordinator : public KeyedService {
return is_canceled_;
}
+ OfflineEventLogger* GetLogger() {
+ return &event_logger_;
+ }
+
private:
void AddRequestResultCallback(RequestQueue::AddRequestResult result,
const SavePageRequest& request);
@@ -136,6 +141,8 @@ class RequestCoordinator : public KeyedService {
std::unique_ptr<RequestPicker> picker_;
// Calling this returns to the scheduler across the JNI bridge.
base::Callback<void(bool)> scheduler_callback_;
+ // Logger to record events.
+ RequestCoordinatorEventLogger event_logger_;
// Allows us to pass a weak pointer to callbacks.
base::WeakPtrFactory<RequestCoordinator> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698