[Offline Pages] Create a event/activity logger

components/offline_pages/background/request_coordinator.cc

Index: components/offline_pages/background/request_coordinator.cc
diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc
index 05ce9ffe9f656143119f54df05814fd7d91a7ccf..98850d659c94102338e39f85cf27fc07bf14e9b7 100644
--- a/components/offline_pages/background/request_coordinator.cc
+++ b/components/offline_pages/background/request_coordinator.cc
@@ -155,6 +155,10 @@ void RequestCoordinator::OfflinerDoneCallback(const SavePageRequest& request,
   DVLOG(2) << "offliner finished, saved: "
            << (status == Offliner::RequestStatus::SAVED) << ", status: "
            << (int) status << ", " << __FUNCTION__;
+  event_logger_.RecordSavePageRequestUpdated(
+      request.client_id().name_space,
+      "Saved",

[dewittj, 2016/06/24 18:32:49]

If this is the only place this is called, I'd probably just remove the "Saved"
parameter and embed it into the log message.

[chili, 2016/06/24 20:30:10]

Ideally (probably in another CL), we can move the Status -> string method in
offline_internals_ui to here and call that to convert the string.  For a start,
though, I think the status parameter has a high chance of being very useful as
pete updates and completes the request coordinator.

+      std::to_string(request.request_id()));

[dewittj, 2016/06/24 18:32:49]

Seems like you could just pass the request_id here and do the string conversion
over in the logger.

[chili, 2016/06/24 20:30:10]

Done.

   last_offlining_status_ = status;
 
   is_busy_ = false;
@@ -174,9 +178,9 @@ void RequestCoordinator::OfflinerDoneCallback(const SavePageRequest& request,
 }
 
 void RequestCoordinator::GetOffliner() {
-    if (!offliner_) {
-      offliner_ = factory_->GetOffliner(policy_.get());
-    }
+  if (!offliner_) {
+    offliner_ = factory_->GetOffliner(policy_.get());
+  }
 }
 
 }  // namespace offline_pages