[Offline Pages] Create a event/activity logger

components/offline_pages/background/request_coordinator.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/background/request_coordinator.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 137 matching lines @@
   offliner_->LoadAndSave(request,
                          base::Bind(&RequestCoordinator::OfflinerDoneCallback,
                                     weak_ptr_factory_.GetWeakPtr()));
 }
 
 void RequestCoordinator::OfflinerDoneCallback(const SavePageRequest& request,
                                               Offliner::RequestStatus status) {
   DVLOG(2) << "offliner finished, saved: "
            << (status == Offliner::RequestStatus::SAVED) << ", status: "
            << (int) status << ", " << __FUNCTION__;
+  event_logger_.RecordSavePageRequestUpdated(
+      request.client_id().name_space,
+      "Saved",

[dewittj, 2016/06/24 18:32:49]

If this is the only place this is called, I'd probably just remove the "Saved"
parameter and embed it into the log message.

[chili, 2016/06/24 20:30:10]

Ideally (probably in another CL), we can move the Status -> string method in
offline_internals_ui to here and call that to convert the string.  For a start,
though, I think the status parameter has a high chance of being very useful as
pete updates and completes the request coordinator.

+      std::to_string(request.request_id()));

[dewittj, 2016/06/24 18:32:49]

Seems like you could just pass the request_id here and do the string conversion
over in the logger.

[chili, 2016/06/24 20:30:10]

Done.

   last_offlining_status_ = status;
 
   is_busy_ = false;
 
   // If the request succeeded, remove it from the Queue and maybe schedule
   // another one.
   if (status == Offliner::RequestStatus::SAVED) {
     queue_->RemoveRequest(request.request_id(),
                           base::Bind(&RequestCoordinator::UpdateRequestCallback,
                                      weak_ptr_factory_.GetWeakPtr()));
 
     // TODO(petewil): Check time budget. Return to the scheduler if we are out.
 
     // Start another request if we have time.
     TryNextRequest();
   }
 }
 
 void RequestCoordinator::GetOffliner() {
-    if (!offliner_) {
-      offliner_ = factory_->GetOffliner(policy_.get());
-    }
+  if (!offliner_) {
+    offliner_ = factory_->GetOffliner(policy_.get());
+  }
 }
 
 }  // namespace offline_pages